Changeset 133179 in webkit

Timestamp:

Nov 1, 2012, 8:40:31 AM (12 years ago)

Author:

aroben@webkit.org

Message:

Crash beneath WKRelease after failed load in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=100954

Reviewed by Sam Weinig.

There were just some simple retain/release bugs.

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController updateTextFieldFromURL:]):
(-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
Don't try to release null URLs.

(-[WK2BrowserWindowController updateCommittedURLForFrame:]): Don't
release a URL for which we don't have ownership.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/mac/WK2BrowserWindowController.m (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-11-01  Adam Roben  <aroben@webkit.org>
+
+        Crash beneath WKRelease after failed load in MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=100954
+
+        Reviewed by Sam Weinig.
+
+        There were just some simple retain/release bugs.
+
+        * MiniBrowser/mac/WK2BrowserWindowController.m:
+        (-[WK2BrowserWindowController updateTextFieldFromURL:]):
+        (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
+        Don't try to release null URLs.
+
+        (-[WK2BrowserWindowController updateCommittedURLForFrame:]): Don't
+        release a URL for which we don't have ownership.
+
 2012-10-31  Rob Buis  <rbuis@rim.com>
 

trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m

@@ -734 +734 @@
         emptyURL = WKURLCreateWithUTF8CString("");
 
-    if (WKURLIsEqual(URLRef, emptyURL)) {
-        WKRelease(URLRef);
-        return;
-    }
+    if (WKURLIsEqual(URLRef, emptyURL))
+        return;
 
     CFURLRef cfSourceURL = WKURLCopyCFURL(0, URLRef);
@@ -747 +745 @@
 {
     WKURLRef url = WKFrameCopyProvisionalURL(frame);
+    if (!url)
+        return;
     [self updateTextFieldFromURL:url];
     WKRelease(url);
@@ -754 +754 @@
 {
     WKURLRef url = WKFrameCopyURL(frame);
+    if (!url)
+        return;
     [self updateTextFieldFromURL:url];
     WKRelease(url);