Changeset 133314 in webkit

Timestamp:

Nov 2, 2012, 10:46:55 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Adding window.external to our port
​https://bugs.webkit.org/show_bug.cgi?id=100868

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-11-02
Reviewed by Rob Buis.
PR 158809

Patch up an error where we were dereferencing a null pointer.

• WebCoreSupport/ExternalExtension.cpp:

(addSearchProviderMethod):
(IsSearchProviderInstalledMethod):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ExternalExtension.cpp (modified) (2 diffs)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-11-02  Otto Derek Cheung  <otcheung@rim.com>
+
+        [BlackBerry] Adding window.external to our port
+        https://bugs.webkit.org/show_bug.cgi?id=100868
+
+        Reviewed by Rob Buis.
+        PR 158809
+
+        Patch up an error where we were dereferencing a null pointer.
+
+        * WebCoreSupport/ExternalExtension.cpp:
+        (addSearchProviderMethod):
+        (IsSearchProviderInstalledMethod):
+
 2012-11-01  Peter Wang  <peter.wang@torchmobile.com.cn>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/ExternalExtension.cpp

@@ -47 +47 @@
     // Double check if page chrome client exists
     Frame* frame = reinterpret_cast<Frame*>(JSObjectGetPrivate(thisObject));
-    if (!frame) {
+    if (frame) {
         Page* page = frame->page();
         if (!page || !page->chrome())
@@ -76 +76 @@
     // Double check if page chrome client exists
     Frame* frame = reinterpret_cast<Frame*>(JSObjectGetPrivate(thisObject));
-    if (!frame) {
+    if (frame) {
         Page* page = frame->page();
         if (!page || !page->chrome())