Changeset 133318 in webkit

Timestamp:

Nov 2, 2012, 11:27:22 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=100977

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-02
Reviewed by Alexey Proskuryakov.

Call WebPageProxy::close() in EwkViewImpl's destructor to avoid crashes
if other objects keep a reference to the WebPageProxy and try to use
it after the view (and therefore the PageClient) is destroyed.

• UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::~EwkViewImpl):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/EwkViewImpl.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-11-02  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=100977
+
+        Reviewed by Alexey Proskuryakov.
+
+        Call WebPageProxy::close() in EwkViewImpl's destructor to avoid crashes
+        if other objects keep a reference to the WebPageProxy and try to use
+        it after the view (and therefore the PageClient) is destroyed.
+
+        * UIProcess/API/efl/EwkViewImpl.cpp:
+        (EwkViewImpl::~EwkViewImpl):
+
 2012-11-02  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp

@@ -159 +159 @@
 EwkViewImpl::~EwkViewImpl()
 {
+    m_pageProxy->close();
+
     // Unregister icon change callback.
     Ewk_Favicon_Database* iconDatabase = m_context->faviconDatabase();