Changeset 133322 in webkit


Ignore:
Timestamp:
Nov 2, 2012, 11:45:09 AM (12 years ago)
Author:
vollick@chromium.org
Message:

[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=98523

Reviewed by Simon Fraser.

The repaint-subrect-grid.html layout test is now text-based and
doesn't use testRunner.displayInvalidatedRegion().

  • fast/images/repaint-subrect-grid-expected.txt:
  • fast/images/repaint-subrect-grid.html:
  • platform/chromium/fast/images/repaint-subrect-grid-expected.png: Removed.
  • platform/efl/fast/images/repaint-subrect-grid-expected.png: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/fast/images/repaint-subrect-grid-expected.txt: Added.
  • platform/qt/TestExpectations:
Location:
trunk/LayoutTests
Files:
1 added
2 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r133320 r133322  
     12012-11-02  Ian Vollick  <vollick@chromium.org>
     2
     3        [Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
     4        https://bugs.webkit.org/show_bug.cgi?id=98523
     5
     6        Reviewed by Simon Fraser.
     7
     8        The repaint-subrect-grid.html layout test is now text-based and
     9        doesn't use testRunner.displayInvalidatedRegion().
     10
     11        * fast/images/repaint-subrect-grid-expected.txt:
     12        * fast/images/repaint-subrect-grid.html:
     13        * platform/chromium/fast/images/repaint-subrect-grid-expected.png: Removed.
     14        * platform/efl/fast/images/repaint-subrect-grid-expected.png: Removed.
     15        * platform/mac/TestExpectations:
     16        * platform/mac/fast/images/repaint-subrect-grid-expected.txt: Added.
     17        * platform/qt/TestExpectations:
     18
    1192012-11-02  Alice Boxhall  <aboxhall@google.com>
    220

  • trunk/LayoutTests/fast/images/repaint-subrect-grid-expected.txt

    r130412 r133322  
     1(repaint rects
     2  (rect -100 -100 18 18)
     3  (rect 0 0 18 18)
     4  (rect 0 0 18 18)
     5  (rect 18 0 19 18)
     6  (rect 18 0 19 18)
     7  (rect 37 0 18 18)
     8  (rect 37 0 18 18)
     9  (rect -9 18 18 19)
     10  (rect -9 18 18 19)
     11  (rect 9 18 18 19)
     12  (rect 9 18 18 19)
     13  (rect 28 18 18 19)
     14  (rect 28 18 18 19)
     15  (rect 46 18 18 19)
     16  (rect 46 18 18 19)
     17  (rect 0 37 18 18)
     18  (rect 0 37 18 18)
     19  (rect 18 37 19 18)
     20  (rect 18 37 19 18)
     21  (rect 37 37 18 18)
     22  (rect 37 37 18 18)
     23  (rect -100 -100 18 18)
     24)
    125

  • trunk/LayoutTests/fast/images/repaint-subrect-grid.html

    r130412 r133322  
    11<html>
    22<head>
    3 <script>
    4 if (window.testRunner) {
    5     testRunner.testRepaint();
    6     testRunner.dumpAsText(true);
    7 }
     3<script src="../repaint/resources/text-based-repaint.js"></script>
     4</head>
     5<body style="background: url(resources/grid-large.png) no-repeat; background-size: 55px 55px;">
     6    <div id="mask" style="position: absolute; top: -100px; left: -100px;
     7                          background-color: blue; width: 18.33px; height: 18.33px;"></div>
     8    <script>
     9        var pos = [
     10            // First row.
     11            [0, 0],
     12            [0, 18.33],
     13            [0, 36.67],
    814
    9 var pos = [
    10     // First row.
    11     [0, 0],
    12     [0, 18.33],
    13     [0, 36.67],
     15            // Second row.
     16            [18.33, -9.17],
     17            [18.33, 9.17],
     18            [18.33, 27.5],
     19            [18.33, 45.83],
    1420
    15     // Second row.
    16     [18.33, -9.17],
    17     [18.33, 9.17],
    18     [18.33, 27.5],
    19     [18.33, 45.83],
     21            // Third row.
     22            [36.67, 0],
     23            [36.67, 18.33],
     24            [36.67, 36.67],
    2025
    21     // Third row.
    22     [36.67, 0],
    23     [36.67, 18.33],
    24     [36.67, 36.67],
     26            // Disappear.
     27            [-100, -100],
     28        ];
    2529
    26     // Disappear.
    27     [-100, -100],
    28 ];
    29 var currentPos = 0;
     30        var currentPos = 0;
    3031
    31 function runTest()
    32 {
    33     if (currentPos >= pos.length)
    34         return;
     32        function repaintTest()
     33        {
     34            if (currentPos >= pos.length)
     35                return;
    3536
    36     var mask = document.getElementById("mask");
    37     mask.style.top = pos[currentPos][0];
    38     mask.style.left = pos[currentPos][1];
    39     ++currentPos;
     37            var mask = document.getElementById("mask");
     38            mask.style.top = pos[currentPos][0];
     39            mask.style.left = pos[currentPos][1];
     40            ++currentPos;
    4041
    41     if (window.testRunner) {
    42         testRunner.displayInvalidatedRegion();
    43         runTest();
    44     } else {
    45         setTimeout("runTest();", 1000);
    46     }
    47 }
    48 </script>
    49 </head>
    50 <body onload="runTest();"
    51       style="background: url(resources/grid-large.png) no-repeat; background-size: 55px 55px;">
    52 <div id="mask" style="position: absolute; top: -100px; left: -100px;
    53                       background-color: blue; width: 18.33px; height: 18.33px;"></div>
     42            // Force a style recalc.
     43            document.body.offsetWidth;
     44
     45            if (window.testRunner)
     46                repaintTest();
     47            else
     48                setTimeout("repaintTest();", 1000);
     49        }
     50
     51        onload = runRepaintTest;
     52    </script>
    5453</body>
    5554</html>

  • trunk/LayoutTests/platform/mac/TestExpectations

    r133263 r133322  
    11351135webkit.org/b/95707 http/tests/images/png-partial-load-no-alpha.html [ ImageOnlyFailure ]
    11361136
    1137 # Requires TestRunner displayInvalidatedRegion() support.
    1138 webkit.org/b/98523 fast/images/repaint-subrect-grid.html [ Failure ]
    1139 
    11401137# Rendering/Layout issue of CJK vertical text with some font.
    11411138webkit.org/b/98560 fast/writing-mode/vertical-subst-font-vert-no-dflt.html [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/qt/TestExpectations

    r133224 r133322  
    12111211
    12121212# Missing layoutTestController.testRepaint()
    1213 fast/images/repaint-subrect-grid.html
    12141213fast/repaint/table-writing-modes-h.html
    12151214fast/repaint/table-writing-modes-v.html
Note: See TracChangeset for help on using the changeset viewer.