Changeset 135333 in webkit


Ignore:
Timestamp:
Nov 20, 2012, 4:45:17 PM (12 years ago)
Author:
dgrogan@chromium.org
Message:

IndexedDB: remove setVersion from pending-version-change-on-exit.html
​https://bugs.webkit.org/show_bug.cgi?id=102457

Reviewed by Tony Chang.

This test doesn't work in single-process mode because of
​http://wkb.ug/82776. We run it in content_shell in chromium.

  • platform/chromium/TestExpectations:
  • storage/indexeddb/pending-version-change-on-exit-expected.txt:
  • storage/indexeddb/pending-version-change-on-exit.html:
  • storage/indexeddb/resources/pending-version-change-on-exit.js:

(request.onblocked):

Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r135314 r135333  
     12012-11-20  David Grogan  <dgrogan@chromium.org>
     2
     3        IndexedDB: remove setVersion from pending-version-change-on-exit.html
     4        https://bugs.webkit.org/show_bug.cgi?id=102457
     5
     6        Reviewed by Tony Chang.
     7
     8        This test doesn't work in single-process mode because of
     9        http://wkb.ug/82776. We run it in content_shell in chromium.
     10
     11        * platform/chromium/TestExpectations:
     12        * storage/indexeddb/pending-version-change-on-exit-expected.txt:
     13        * storage/indexeddb/pending-version-change-on-exit.html:
     14        * storage/indexeddb/resources/pending-version-change-on-exit.js:
     15        (request.onblocked):
     16
    1172012-11-20  Bear Travis  <betravis@adobe.com>
    218

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r135311 r135333  
    33643364webkit.org/b/82776 storage/indexeddb/pending-version-change-stuck.html
    33653365webkit.org/b/82776 storage/indexeddb/pending-version-change-stuck-works-with-terminate.html
     3366webkit.org/b/82776 storage/indexeddb/pending-version-change-on-exit.html
    33663367
    33673368webkit.org/b/ [ Win Release ] http/tests/xmlhttprequest/redirect-cross-origin-post.html [ Failure Pass ]

  • trunk/LayoutTests/storage/indexeddb/pending-version-change-on-exit-expected.txt

    r129090 r135333  
    1 CONSOLE MESSAGE: The setVersion() method is non-standard and will be removed. Use the "upgradeneeded" event instead.
    21No crashes when there are event listeners in a worker on shutdown
    32
    43On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    54
    6 
    7 indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
    85
    96PASS Didn't crash!

  • trunk/LayoutTests/storage/indexeddb/pending-version-change-on-exit.html

    r113818 r135333  
    99description("No crashes when there are event listeners in a worker on shutdown");
    1010
    11 function test() {
    12   removeVendorPrefixes();
    13   if (self.location.search == "?second") {
    14     testPassed("Didn't crash!");
    15     finishJSTest();
    16     return;
    17   }
    18   dbname = "pending-version-change-on-exit";
    19   evalAndLog("request = indexedDB.open(\"" + dbname + "\")");
    20   request.onsuccess = startTheWorker;
    21   request.onblocked = unexpectedBlockedCallback;
    22   request.onerror = unexpectedErrorCallback;
     11if (self.location.search == "?second") {
     12  testPassed("Didn't crash!");
     13  finishJSTest();
     14} else {
     15  evalAndLog("gotVersionChangeEvent = false");
     16  indexedDBTest(prepareDatabase, startTheWorker);
     17}
     18
     19function prepareDatabase()
     20{
     21  debug("inside prepareDatabase");
     22  preamble();
     23  db = event.target.result;
     24  db.onversionchange = function(e) {
     25    evalAndLog("gotVersionChangeEvent = true");
     26    debug("Got a version change event, e.oldVersion = " + e.oldVersion +
     27          " e.newVersion = " + e.newVersion);
     28  };
    2329}
    2430
    2531function startTheWorker() {
    26   var worker = startWorker("resources/pending-version-change-on-exit.js");
     32  var worker = startWorker("resources/pending-version-change-on-exit.js?" + encodeURIComponent(dbname));
    2733  realFinishJSTest = finishJSTest;
    2834  worker.onerror = function(e) {
    … …  
    3137  };
    3238  finishJSTest = function() {
    33     self.location = self.location + "?second";
     39    shouldBeTrue("gotVersionChangeEvent");
     40    if (gotVersionChangeEvent)
     41      self.location = self.location + "?second";
     42    else
     43      realFinishJSTest();
    3444  }
    3545}
    36 
    37 test();
    38 
    3946</script>
    4047<script src="../../fast/js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/storage/indexeddb/resources/pending-version-change-on-exit.js

    r113818 r135333  
    44}
    55
    6 function test() {
    7   removeVendorPrefixes();
    8   dbname = "pending-version-change-on-exit";
    9   evalAndLog("request = indexedDB.open(\"" + dbname + "\")");
    10   request.onsuccess = function(e) {
    11     db = request.result;
    12     evalAndLog("request = db.setVersion(1)");
    13     request.onsuccess = unexpectedSuccessCallback;
    14     request.onblocked = function() {
    15       testPassed("worker received blocked event.");
    16       finishJSTest();
    17     };
    18   };
    19 }
    20 
    21 test();
     6removeVendorPrefixes();
     7dbname = decodeURIComponent(self.location.search.substring(1));
     8evalAndLog("request = indexedDB.open(\"" + dbname + "\", 2)");
     9request.onupgradeneeded = unexpectedUpgradeNeededCallback;
     10request.onblocked = function(e) {
     11    testPassed("worker received blocked event.");
     12    finishJSTest();
     13};
Note: See TracChangeset for help on using the changeset viewer.