Changeset 135416 in webkit

Timestamp:

Nov 21, 2012, 10:21:19 AM (12 years ago)

Author:

tony@chromium.org

Message:

Relayout the slider track when a data list is set
​https://bugs.webkit.org/show_bug.cgi?id=102851

Reviewed by Ojan Vafai.

Previously, we would relayout the <input>. Once we fix bug 102352, this
causes the slider track to not relayout. It should relayout because it
draws the data list tick marks and needs to provide space for them.

No new tests, not testable until bug 102352 is fixed. Specifically,
fast/forms/datalist/update-range-with-datalist.html reveals the bug.

• html/RangeInputType.cpp:

(WebCore::RangeInputType::listAttributeTargetChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/RangeInputType.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-21  Tony Chang  <tony@chromium.org>
+
+        Relayout the slider track when a data list is set
+        https://bugs.webkit.org/show_bug.cgi?id=102851
+
+        Reviewed by Ojan Vafai.
+
+        Previously, we would relayout the <input>.  Once we fix bug 102352, this
+        causes the slider track to not relayout.  It should relayout because it
+        draws the data list tick marks and needs to provide space for them.
+
+        No new tests, not testable until bug 102352 is fixed. Specifically,
+        fast/forms/datalist/update-range-with-datalist.html reveals the bug.
+
+        * html/RangeInputType.cpp:
+        (WebCore::RangeInputType::listAttributeTargetChanged):
+
 2012-11-21  Kevin Ellis  <kevers@chromium.org>
 

trunk/Source/WebCore/html/RangeInputType.cpp

@@ -343 +343 @@
 {
     m_tickMarkValuesDirty = true;
-    if (element()->renderer())
-        element()->renderer()->setNeedsLayout(true);
+    HTMLElement* sliderTrackElement = sliderTrackElementOf(element());
+    if (sliderTrackElement->renderer())
+        sliderTrackElement->renderer()->setNeedsLayout(true);
 }