Changeset 135775 in webkit

Timestamp:

Nov 26, 2012, 3:07:35 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Form controls don't show pressed state.
​https://bugs.webkit.org/show_bug.cgi?id=103292

Patch by Genevieve Mak <​gmak@rim.com> on 2012-11-26
Reviewed by Rob Buis.

Reviewed internally by Eli Fidler and Mike Lattanzio.
We weren't sending touch events to webpages unless they
had JS touch event listeners which form controls don't have.
Now send them always and do a little cleanup.
PR #249791

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::touchEvent):

• Api/WebPageClient.h:
• Api/WebPage_p.h:

(WebPagePrivate):

• WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::needTouchEvents):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPage.cpp (modified) (3 diffs)
• Api/WebPageClient.h (modified) (1 diff)
• Api/WebPage_p.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -373 +373 @@
     , m_resetVirtualViewportOnCommitted(true)
     , m_shouldUseFixedDesktopMode(false)
-    , m_needTouchEvents(false)
     , m_preventIdleDimmingCount(0)
 #if ENABLE(TOUCH_EVENTS)
@@ -4011 +4010 @@
     bool handled = false;
 
-    if (d->m_needTouchEvents && !event.m_type != Platform::TouchEvent::TouchInjected)
+    if (!event.m_type != Platform::TouchEvent::TouchInjected)
         handled = d->m_mainFrame->eventHandler()->handleTouchEvent(PlatformTouchEvent(&tEvent));
 
@@ -5919 +5918 @@
 }
 
-void WebPagePrivate::setNeedTouchEvents(bool value)
-{
-    m_needTouchEvents = value;
-}
-
 void WebPagePrivate::frameUnloaded(const Frame* frame)
 {

trunk/Source/WebKit/blackberry/Api/WebPageClient.h

@@ -104 +104 @@
 
     virtual void notifyInRegionScrollableAreasChanged(const std::vector<Platform::ScrollViewBase*>&) = 0;
-    virtual void notifyNoMouseMoveOrTouchMoveHandlers() = 0;
 
     virtual void notifyDocumentOnLoad(bool) = 0;

trunk/Source/WebKit/blackberry/Api/WebPage_p.h

@@ -491 +491 @@
     bool m_resetVirtualViewportOnCommitted;
     bool m_shouldUseFixedDesktopMode;
-    bool m_needTouchEvents;
     int m_preventIdleDimmingCount;
 

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-11-26  Genevieve Mak  <gmak@rim.com>
+
+        [BlackBerry] Form controls don't show pressed state.
+        https://bugs.webkit.org/show_bug.cgi?id=103292
+
+        Reviewed by Rob Buis.
+
+        Reviewed internally by Eli Fidler and Mike Lattanzio.
+        We weren't sending touch events to webpages unless they
+        had JS touch event listeners which form controls don't have.
+        Now send them always and do a little cleanup.
+        PR #249791
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
+        (BlackBerry::WebKit::WebPage::touchEvent):
+        * Api/WebPageClient.h:
+        * Api/WebPage_p.h:
+        (WebPagePrivate):
+        * WebCoreSupport/ChromeClientBlackBerry.cpp:
+        (WebCore::ChromeClientBlackBerry::needTouchEvents):
+
 2012-11-26  Nima Ghanavatian  <nghanavatian@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

@@ -657 +657 @@
 void ChromeClientBlackBerry::needTouchEvents(bool value)
 {
-    m_webPagePrivate->setNeedTouchEvents(value);
 }
 #endif