Changeset 136033 in webkit

Timestamp:

Nov 28, 2012, 11:37:15 AM (13 years ago)

Author:

Beth Dakin

Message:

​https://bugs.webkit.org/show_bug.cgi?id=102970
[WK1] REGRESSION (r129545): Main frame doesn't rubberband unless
WebFrameLoadDelegate implements -webView:didFirstLayoutInFrame:

Reviewed by Sam Weinig.

We should always register for DidFirstLayout in WK1 since we do work
at that time besides just calling the delegate function.

• WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]):

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebView.mm (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2012-11-28  Beth Dakin  <bdakin@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=102970
+        [WK1] REGRESSION (r129545): Main frame doesn't rubberband unless 
+        WebFrameLoadDelegate implements -webView:didFirstLayoutInFrame:
+
+        Reviewed by Sam Weinig.
+
+        We should always register for DidFirstLayout in WK1 since we do work 
+        at that time besides just calling the delegate function.
+        * WebView/WebView.mm:
+        (-[WebView _cacheFrameLoadDelegateImplementations]):
+
 2012-11-27  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -1687 +1687 @@
     Page* page = core(self);
     if (page) {
-        unsigned milestones = 0;
-        if (cache->didFirstLayoutInFrameFunc)
-            milestones |= DidFirstLayout;
+        unsigned milestones = DidFirstLayout;
         if (cache->didFirstVisuallyNonEmptyLayoutInFrameFunc)
             milestones |= DidFirstVisuallyNonEmptyLayout;