Changeset 136132 in webkit

Timestamp:

Nov 29, 2012, 7:34:39 AM (14 years ago)

Author:

mkwst@chromium.org

Message:

Typo in 'autofocus' sandboxing error message.
​https://bugs.webkit.org/show_bug.cgi?id=103616

Reviewed by Jochen Eisinger.

Source/WebCore:

The sandbox attribute name is 'allow-scripts', not 'allow-script'. :(

• html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

LayoutTests:

• fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLFormControlElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-11-29  Mike West  <mkwst@chromium.org>
+
+        Typo in 'autofocus' sandboxing error message.
+        https://bugs.webkit.org/show_bug.cgi?id=103616
+
+        Reviewed by Jochen Eisinger.
+
+        * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
+
 2012-11-29  Hajime Morrita  <morrita@google.com>
 

trunk/LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied-expected.txt

@@ -1 @@
-CONSOLE MESSAGE: Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-script' permission is not set.
+CONSOLE MESSAGE: Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set.
 CONSOLE MESSAGE: line 13: PASS: The input element is not focused.
 This test passes if the input element in the sandboxed frame is not automatically focused upon, as it should be blocked by the sandboxed scripts flag. A console warning to that effect should also be present.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-29  Mike West  <mkwst@chromium.org>
+
+        Typo in 'autofocus' sandboxing error message.
+        https://bugs.webkit.org/show_bug.cgi?id=103616
+
+        Reviewed by Jochen Eisinger.
+
+        The sandbox attribute name is 'allow-scripts', not 'allow-script'. :(
+
+        * html/HTMLFormControlElement.cpp:
+        (WebCore::shouldAutofocus):
+
 2012-11-29  Hajime Morrita  <morrita@google.com>
 

trunk/Source/WebCore/html/HTMLFormControlElement.cpp

@@ -175 +175 @@
     if (element->document()->isSandboxed(SandboxAutomaticFeatures)) {
         // FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
-        element->document()->addConsoleMessage(HTMLMessageSource, LogMessageType, ErrorMessageLevel, "Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-script' permission is not set.");
+        element->document()->addConsoleMessage(HTMLMessageSource, LogMessageType, ErrorMessageLevel, "Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set.");
         return false;
     }