Changeset 136145 in webkit

Timestamp:

Nov 29, 2012, 12:06:37 PM (14 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: introduce fast case for within-chunk edit
​https://bugs.webkit.org/show_bug.cgi?id=103545

Reviewed by Vsevolod Vlasov.

Special-casing edits within the chunk for faster operation.

• inspector/front-end/DOMExtension.js:

(removeSubsequentNodes):

• inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DOMExtension.js (modified) (1 diff)
• inspector/front-end/DefaultTextEditor.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-29  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: introduce fast case for within-chunk edit
+        https://bugs.webkit.org/show_bug.cgi?id=103545
+
+        Reviewed by Vsevolod Vlasov.
+
+        Special-casing edits within the chunk for faster operation.
+
+        * inspector/front-end/DOMExtension.js:
+        (removeSubsequentNodes):
+        * inspector/front-end/DefaultTextEditor.js:
+        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
+
 2012-11-29  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DOMExtension.js

@@ -196 +196 @@
 }
 
+/**
+ * @param {Node} fromNode
+ * @param {Node} toNode
+ */
+function removeSubsequentNodes(fromNode, toNode)
+{
+    for (var node = fromNode; node && node !== toNode; ) {
+        var nodeToRemove = node;
+        node = node.nextSibling;
+        nodeToRemove.remove();
+    }
+}
 
 /**

trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js

@@ -2416 +2416 @@
         var lastUndamagedChunk = firstDamagedChunkNumber > 0 ? this._textChunks[firstDamagedChunkNumber - 1] : null;
         var firstUndamagedChunk = lastDamagedChunkNumber + 1 < this._textChunks.length ? this._textChunks[lastDamagedChunkNumber + 1] : null;
+
         var removeDOMFromNode = lastUndamagedChunk ? lastUndamagedChunk.lastElement().nextSibling : this._container.firstChild;
         var removeDOMToNode = firstUndamagedChunk ? firstUndamagedChunk.firstElement() : null;
-        for (var node = removeDOMFromNode; node && node !== removeDOMToNode; ) {
-            var nodeToRemove = node;
-            node = node.nextSibling;
-            nodeToRemove.remove();
-        }
+
+        // Fast case - patch single expanded chunk that did not grow / shrink during edit.
+        if (!linesDiff && firstDamagedChunk === lastDamagedChunk && firstDamagedChunk._expandedLineRows) {
+            var lastUndamagedLineRow = lastDamagedChunk.expandedLineRow(oldRange.startLine - 1);
+            var firstUndamagedLineRow = firstDamagedChunk.expandedLineRow(oldRange.endLine + 1);
+            var localRemoveDOMFromNode = lastUndamagedLineRow ? lastUndamagedLineRow.nextSibling : removeDOMFromNode;
+            var localRemoveDOMToNode = firstUndamagedLineRow || removeDOMToNode;
+            removeSubsequentNodes(localRemoveDOMFromNode, localRemoveDOMToNode);
+            for (var i = newRange.startLine; i < newRange.endLine + 1; ++i) {
+                var row = firstDamagedChunk._createRow(i);
+                firstDamagedChunk._expandedLineRows[i - firstDamagedChunk.startLine] = row;
+                this._container.insertBefore(row, localRemoveDOMToNode);
+            }
+            firstDamagedChunk.updateCollapsedLineRow();
+            this._assertDOMMatchesTextModel();
+            return;
+        }
+
+        removeSubsequentNodes(removeDOMFromNode, removeDOMToNode);
         this._textChunks.splice(firstDamagedChunkNumber, lastDamagedChunkNumber - firstDamagedChunkNumber + 1);