Changeset 136162 in webkit

Timestamp:

Nov 29, 2012, 2:13:29 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Modifying GeoClientBlackBerry to switch between high and low accuracy
​https://bugs.webkit.org/show_bug.cgi?id=103666

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-11-29
Reviewed by Yong Li.

Internally reviewed by Yong Li.

PR 243420

Updating GeolocationClientBlackBerry to switch accuracy when GeolocationController
calls setEnableHighAccuracy.

• WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::startUpdating):
(GeolocationClientBlackBerry::setEnableHighAccuracy):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/GeolocationClientBlackBerry.cpp (modified) (2 diffs)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-11-29  Otto Derek Cheung  <otcheung@rim.com>
+
+        [BlackBerry] Modifying GeoClientBlackBerry to switch between high and low accuracy
+        https://bugs.webkit.org/show_bug.cgi?id=103666
+
+        Reviewed by Yong Li.
+
+        Internally reviewed by Yong Li.
+
+        PR 243420
+
+        Updating GeolocationClientBlackBerry to switch accuracy when GeolocationController
+        calls setEnableHighAccuracy.
+
+        * WebCoreSupport/GeolocationClientBlackBerry.cpp:
+        (GeolocationClientBlackBerry::startUpdating):
+        (GeolocationClientBlackBerry::setEnableHighAccuracy):
+
 2012-11-29  Andrew Lo  <anlo@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp

@@ -53 +53 @@
 {
     if (!m_isActive)
-        BlackBerry::Platform::GeolocationHandler::instance()->addListener(this, false);
+        BlackBerry::Platform::GeolocationHandler::instance()->addListener(this);
     m_isActive = true;
 }
@@ -130 +130 @@
 void GeolocationClientBlackBerry::setEnableHighAccuracy(bool newAccuracy)
 {
-    // FIXME: we have to implement high accuracy on our side too
-    m_accuracy = newAccuracy;
+    if (m_accuracy != newAccuracy) {
+        m_accuracy = newAccuracy;
+        BlackBerry::Platform::GeolocationHandler::instance()->switchAccuracy(this);
+    }
 }