Changeset 136172 in webkit

Timestamp:

Nov 29, 2012, 3:16:13 PM (14 years ago)

Author:

andersca@apple.com

Message:

CoreIPC::Connection should retain its xpc_connection_t
​https://bugs.webkit.org/show_bug.cgi?id=103671
<rdar://problem/12717331>

Reviewed by Beth Dakin.

• Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::platformInitialize):
Retain the xpc_connection_t object here to balance the xpc_object_release in platformInvalidate.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/mac/ConnectionMac.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-11-29  Anders Carlsson  <andersca@apple.com>
+
+        CoreIPC::Connection should retain its xpc_connection_t
+        https://bugs.webkit.org/show_bug.cgi?id=103671
+        <rdar://problem/12717331>
+
+        Reviewed by Beth Dakin.
+
+        * Platform/CoreIPC/mac/ConnectionMac.cpp:
+        (CoreIPC::Connection::platformInitialize):
+        Retain the xpc_connection_t object here to balance the xpc_object_release in platformInvalidate.
+
 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp

@@ -93 +93 @@
 
 #if HAVE(XPC)
-    m_xpcConnection = identifier.xpcConnection;
+    // FIXME: Instead of explicitly retaining the connection here, Identifier::xpcConnection
+    // should just be a smart pointer.
+    if (identifier.xpcConnection)
+        m_xpcConnection = static_cast<xpc_connection_t>(xpc_retain(identifier.xpcConnection));
 #endif
 }