Changeset 136187 in webkit

Timestamp:

Nov 29, 2012, 5:06:47 PM (14 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: optimize repaint regions upon text editing
​https://bugs.webkit.org/show_bug.cgi?id=103674

Reviewed by Vsevolod Vlasov.

There is a lot happening that makes repaint area larger than it should be,
namely unnecessary tabbed pane and navigator updates.

• inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._updateScriptTitle):

• inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype.set title):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/NavigatorView.js (modified) (1 diff)
• inspector/front-end/TabbedPane.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-29  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: optimize repaint regions upon text editing
+        https://bugs.webkit.org/show_bug.cgi?id=103674
+
+        Reviewed by Vsevolod Vlasov.
+
+        There is a lot happening that makes repaint area larger than it should be,
+        namely unnecessary tabbed pane and navigator updates.
+
+        * inspector/front-end/NavigatorView.js:
+        (WebInspector.NavigatorView.prototype._updateScriptTitle):
+        * inspector/front-end/TabbedPane.js:
+        (WebInspector.TabbedPaneTab.prototype.set title):
+
 2012-11-29  KyungTae Kim  <ktf.kim@samsung.com>
 

trunk/Source/WebCore/inspector/front-end/NavigatorView.js

@@ -480 +480 @@
     set titleText(titleText)
     {
+        if (this._titleText === titleText)
+            return;
         this._titleText = titleText || "";
         if (this.titleElement)

trunk/Source/WebCore/inspector/front-end/TabbedPane.js

@@ -599 +599 @@
     set title(title)
     {
+        if (title === this._title)
+            return;
         this._title = title;
         if (this._titleElement)