Changeset 136190 in webkit

Timestamp:

Nov 29, 2012, 5:25:07 PM (14 years ago)

Author:

andersca@apple.com

Message:

Initialize m_xpcConnection to null if the identifier doesn't have an XPC connection
​https://bugs.webkit.org/show_bug.cgi?id=103689

Reviewed by Darin Adler.

• Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::platformInitialize):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/mac/ConnectionMac.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-11-29  Anders Carlsson  <andersca@apple.com>
+
+        Initialize m_xpcConnection to null if the identifier doesn't have an XPC connection
+        https://bugs.webkit.org/show_bug.cgi?id=103689
+
+        Reviewed by Darin Adler.
+
+        * Platform/CoreIPC/mac/ConnectionMac.cpp:
+        (CoreIPC::Connection::platformInitialize):
+
 2012-11-29  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp

@@ -93 +93 @@
 
 #if HAVE(XPC)
+    m_xpcConnection = identifier.xpcConnection;
     // FIXME: Instead of explicitly retaining the connection here, Identifier::xpcConnection
     // should just be a smart pointer.
-    if (identifier.xpcConnection)
-        m_xpcConnection = static_cast<xpc_connection_t>(xpc_retain(identifier.xpcConnection));
+    if (m_xpcConnection)
+        xpc_retain(m_xpcConnection);
 #endif
 }