Changeset 136414 in webkit

Timestamp:

Dec 3, 2012, 10:44:10 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Implement context menus in CodeMirrorTextEditor
​https://bugs.webkit.org/show_bug.cgi?id=94062

Patch by Jan Keromnes <​janx@linux.com> on 2012-12-03
Reviewed by Pavel Feldman.

Listen for contextmenu events in the editor and handle them differently
if triggered on gutter line number or in text body. This adds controls
for breakpoints (including disabled / conditional), debugger navigation
and text input methods.

• inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._contextMenu):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/CodeMirrorTextEditor.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-03  Jan Keromnes  <janx@linux.com>
+
+        Web Inspector: Implement context menus in CodeMirrorTextEditor
+        https://bugs.webkit.org/show_bug.cgi?id=94062
+
+        Reviewed by Pavel Feldman.
+
+        Listen for contextmenu events in the editor and handle them differently
+        if triggered on gutter line number or in text body. This adds controls
+        for breakpoints (including disabled / conditional), debugger navigation
+        and text input methods.
+
+        * inspector/front-end/CodeMirrorTextEditor.js:
+        (WebInspector.CodeMirrorTextEditor):
+        (WebInspector.CodeMirrorTextEditor.prototype._contextMenu):
+
 2012-12-03  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js

@@ -58 +58 @@
     this._codeMirror.on("change", this._change.bind(this));
     this._codeMirror.on("gutterClick", this._gutterClick.bind(this));
+    this.element.addEventListener("contextmenu", this._contextMenu.bind(this));
 
     this._lastRange = this.range();
@@ -125 +126 @@
     {
         this.dispatchEventToListeners(WebInspector.TextEditor.Events.GutterClick, { lineNumber: lineNumber, event: event });
+    },
+
+    _contextMenu: function(event)
+    {
+        var contextMenu = new WebInspector.ContextMenu(event);
+        var target = event.target.enclosingNodeOrSelfWithClass("CodeMirror-gutter-elt");
+        if (target)
+            this._delegate.populateLineGutterContextMenu(contextMenu, parseInt(target.textContent, 10) - 1);
+        else
+            this._delegate.populateTextAreaContextMenu(contextMenu, null);
+        contextMenu.show();
     },