Changeset 136448 in webkit


Ignore:
Timestamp:
Dec 3, 2012, 3:43:27 PM (13 years ago)
Author:
caseq@chromium.org
Message:

Web Inspector: make it possible to fliter out messages from console.{time,timeEnd}()
​https://bugs.webkit.org/show_bug.cgi?id=103781

Reviewed by Yury Semikhatsky.

  • make console messages produced by console.timeEnd() TimingMessageType & DebugMessageLevel;
  • add console filter for Debug messages;
  • inspector/ConsoleMessage.cpp:

(WebCore::messageTypeValue):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):

  • inspector/front-end/inspector.css:

(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
(.filter-all .console-debug-level, .filter-debug .console-debug-level):
(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):

  • page/ConsoleTypes.h:
Location:
trunk/Source/WebCore
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r136446 r136448  
     12012-11-30  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Web Inspector: make it possible to fliter out messages from console.{time,timeEnd}()
     4        https://bugs.webkit.org/show_bug.cgi?id=103781
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        - make console messages produced by console.timeEnd() TimingMessageType & DebugMessageLevel;
     9        - add console filter for Debug messages;
     10
     11        * inspector/ConsoleMessage.cpp:
     12        (WebCore::messageTypeValue):
     13        * inspector/Inspector.json:
     14        * inspector/InspectorConsoleAgent.cpp:
     15        (WebCore::InspectorConsoleAgent::stopTiming):
     16        * inspector/front-end/ConsoleMessage.js:
     17        (WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
     18        * inspector/front-end/ConsoleView.js:
     19        (WebInspector.ConsoleView.prototype.):
     20        (WebInspector.ConsoleView.prototype.filter):
     21        * inspector/front-end/inspector.css:
     22        (.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
     23        (.filter-all .console-debug-level, .filter-debug .console-debug-level):
     24        (.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):
     25        * page/ConsoleTypes.h:
     26
    1272012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
    228

  • trunk/Source/WebCore/inspector/ConsoleMessage.cpp

    r136386 r136448  
    108108    case EndGroupMessageType: return TypeBuilder::Console::ConsoleMessage::Type::EndGroup;
    109109    case AssertMessageType: return TypeBuilder::Console::ConsoleMessage::Type::Assert;
     110    case TimingMessageType: return TypeBuilder::Console::ConsoleMessage::Type::Timing;
    110111    }
    111112    return TypeBuilder::Console::ConsoleMessage::Type::Log;

  • trunk/Source/WebCore/inspector/Inspector.json

    r136144 r136448  
    676676                    { "name": "level", "type": "string", "enum": ["tip", "log", "warning", "error", "debug"], "description": "Message severity." },
    677677                    { "name": "text", "type": "string", "description": "Message text." },
    678                     { "name": "type", "type": "string", "optional": true, "enum": ["log", "dir", "dirxml", "trace", "clear", "startGroup", "startGroupCollapsed", "endGroup", "assert"], "description": "Console message type." },
     678                    { "name": "type", "type": "string", "optional": true, "enum": ["log", "dir", "dirxml", "trace", "clear", "startGroup", "startGroupCollapsed", "endGroup", "assert", "timing"], "description": "Console message type." },
    679679                    { "name": "url", "type": "string", "optional": true, "description": "URL of the message origin." },
    680680                    { "name": "line", "type": "integer", "optional": true, "description": "Line number in the resource that generated this message." },

  • trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp

    r136386 r136448  
    228228    String message = title + String::format(": %.3fms", elapsed * 1000);
    229229    const ScriptCallFrame& lastCaller = callStack->at(0);
    230     addMessageToConsole(JSMessageSource, LogMessageType, LogMessageLevel, message, lastCaller.sourceURL(), lastCaller.lineNumber());
     230    addMessageToConsole(JSMessageSource, TimingMessageType, DebugMessageLevel, message, lastCaller.sourceURL(), lastCaller.lineNumber());
    231231}
    232232

  • trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js

    r136144 r136448  
    611611
    612612        switch (this.level) {
    613             case WebInspector.ConsoleMessage.MessageLevel.Tip:
    614                 element.addStyleClass("console-tip-level");
    615                 break;
    616             case WebInspector.ConsoleMessage.MessageLevel.Log:
    617                 element.addStyleClass("console-log-level");
    618                 break;
    619             case WebInspector.ConsoleMessage.MessageLevel.Debug:
    620                 element.addStyleClass("console-debug-level");
    621                 break;
    622             case WebInspector.ConsoleMessage.MessageLevel.Warning:
    623                 element.addStyleClass("console-warning-level");
    624                 break;
    625             case WebInspector.ConsoleMessage.MessageLevel.Error:
    626                 element.addStyleClass("console-error-level");
    627                 break;
     613        case WebInspector.ConsoleMessage.MessageLevel.Tip:
     614            element.addStyleClass("console-tip-level");
     615            break;
     616        case WebInspector.ConsoleMessage.MessageLevel.Log:
     617            element.addStyleClass("console-log-level");
     618            break;
     619        case WebInspector.ConsoleMessage.MessageLevel.Debug:
     620            element.addStyleClass("console-debug-level");
     621            break;
     622        case WebInspector.ConsoleMessage.MessageLevel.Warning:
     623            element.addStyleClass("console-warning-level");
     624            break;
     625        case WebInspector.ConsoleMessage.MessageLevel.Error:
     626            element.addStyleClass("console-error-level");
     627            break;
    628628        }
    629629

  • trunk/Source/WebCore/inspector/front-end/ConsoleView.js

    r135487 r136448  
    9999    this.warningElement = createFilterElement.call(this, "warnings", WebInspector.UIString("Warnings"));
    100100    this.logElement = createFilterElement.call(this, "logs", WebInspector.UIString("Logs"));
     101    this.debugElement = createFilterElement.call(this, "debug", WebInspector.UIString("Debug"));
    101102
    102103    this.filter(this.allElement, false);
    … …  
    267268            this.warningElement.removeStyleClass("selected");
    268269            this.logElement.removeStyleClass("selected");
    269 
    270             this.messagesElement.removeStyleClass("filter-all");
    271             this.messagesElement.removeStyleClass("filter-errors");
    272             this.messagesElement.removeStyleClass("filter-warnings");
    273             this.messagesElement.removeStyleClass("filter-logs");
     270            this.debugElement.removeStyleClass("selected");
     271
     272            this.messagesElement.classList.remove("filter-all", "filter-errors", "filter-warnings", "filter-logs", "filter-debug");
    274273        }
    275274

  • trunk/Source/WebCore/inspector/front-end/inspector.css

    r136144 r136448  
    20062006}
    20072007
    2008 .console-warning-level, .console-error-level, .console-log-level {
     2008.console-warning-level, .console-error-level, .console-log-level, .console-debug-level {
    20092009    display: none;
    20102010}
    … …  
    20122012.filter-all .console-warning-level, .filter-warnings .console-warning-level,
    20132013.filter-all .console-error-level, .filter-errors .console-error-level,
    2014 .filter-all .console-log-level, .filter-logs .console-log-level {
     2014.filter-all .console-log-level, .filter-logs .console-log-level,
     2015.filter-all .console-debug-level, .filter-debug .console-debug-level {
    20152016    display: block;
    20162017}
    … …  
    20182019.filter-all .console-warning-level.repeated-message, .filter-warnings .console-warning-level.repeated-message,
    20192020.filter-all .console-error-level.repeated-message, .filter-errors .console-error-level.repeated-message,
    2020 .filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message {
     2021.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message,
     2022.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message {
    20212023    display: -webkit-flex;
    20222024}

  • trunk/Source/WebCore/page/ConsoleTypes.h

    r133614 r136448  
    4949    EndGroupMessageType,
    5050    ClearMessageType,
    51     AssertMessageType
     51    AssertMessageType,
     52    TimingMessageType
    5253};
    5354
Note: See TracChangeset for help on using the changeset viewer.