Changeset 136555 in webkit

Timestamp:

Dec 4, 2012, 1:10:38 PM (12 years ago)

Author:

abarth@webkit.org

Message:

Remove obsolete code from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=104029

Reviewed by Eric Seidel.

• Scripts/webkitpy/tool/bot/commitqueuetask.py:

(CommitQueueTask.run):

• Scripts/webkitpy/tool/steps/commit.py:

(Commit.options):

• Scripts/webkitpy/tool/steps/options.py:

(Options):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/commitqueuetask.py (modified) (1 diff)
• Scripts/webkitpy/tool/steps/commit.py (modified) (1 diff)
• Scripts/webkitpy/tool/steps/options.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-12-04  Adam Barth  <abarth@webkit.org>
+
+        Remove obsolete code from webkitpy
+        https://bugs.webkit.org/show_bug.cgi?id=104029
+
+        Reviewed by Eric Seidel.
+
+        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
+        (CommitQueueTask.run):
+        * Scripts/webkitpy/tool/steps/commit.py:
+        (Commit.options):
+        * Scripts/webkitpy/tool/steps/options.py:
+        (Options):
+
 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py

@@ -89 +89 @@
         if not self.validate():
             return False
-        # FIXME: We should understand why the land failure occured and retry if possible.
+        # FIXME: We should understand why the land failure occurred and retry if possible.
         if not self._land():
             return self.report_failure()

trunk/Tools/Scripts/webkitpy/tool/steps/commit.py

@@ -41 +41 @@
 
 class Commit(AbstractStep):
-    # FIXME: This option exists only to make sure we don't break scripts which include --ignore-builders
-    # You can safely delete this option any time after 11/01/11.
     @classmethod
     def options(cls):
         return AbstractStep.options() + [
-            Options.check_builders,
             Options.non_interactive,
         ]

trunk/Tools/Scripts/webkitpy/tool/steps/options.py

@@ -34 +34 @@
     build_style = make_option("--build-style", action="store", dest="build_style", default=None, help="Whether to build debug, release, or both.")
     cc = make_option("--cc", action="store", type="string", dest="cc", help="Comma-separated list of email addresses to carbon-copy.")
-    check_builders = make_option("--ignore-builders", action="store_false", dest="check_builders", default=True, help="DEPRECATED: Will be removed any time after 11/01/11.")
     check_style = make_option("--ignore-style", action="store_false", dest="check_style", default=True, help="Don't check to see if the patch has proper style before uploading.")
     check_style_filter = make_option("--check-style-filter", action="store", type="string", dest="check_style_filter", default=None, help="Filter style-checker rules (see check-webkit-style --help).")