Changeset 136598 in webkit

Timestamp:

Dec 4, 2012, 5:05:53 PM (12 years ago)

Author:

aestes@apple.com

Message:

[WebKit2] WKWebProcessPlugInBrowserContextControllers should be treated as type WKBrowsingContextControllerType for encoding purposes
​https://bugs.webkit.org/show_bug.cgi?id=104063

Reviewed by Sam Weinig.

Objective-C message graphs can include browsing context controller
objects, which are decoded as WKWebProcessPlugInBrowserContextControllers
in the web process plug-in and as WKBrowsingContextControllers in the UI
process. Ensure we correctly encode WKWebProcessPlugInBrowserContextControllers
by treating them as type WKBrowsingContextControllerType.

• Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::typeFromObject):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/ObjCObjectGraphCoders.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-12-04  Andy Estes  <aestes@apple.com>
+
+        [WebKit2] WKWebProcessPlugInBrowserContextControllers should be treated as type WKBrowsingContextControllerType for encoding purposes
+        https://bugs.webkit.org/show_bug.cgi?id=104063
+
+        Reviewed by Sam Weinig.
+
+        Objective-C message graphs can include browsing context controller
+        objects, which are decoded as WKWebProcessPlugInBrowserContextControllers
+        in the web process plug-in and as WKBrowsingContextControllers in the UI
+        process. Ensure we correctly encode WKWebProcessPlugInBrowserContextControllers
+        by treating them as type WKBrowsingContextControllerType.
+
+        * Shared/mac/ObjCObjectGraphCoders.mm:
+        (WebKit::typeFromObject):
+
 2012-12-04  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm

@@ -76 +76 @@
         return NSDataType;
 #if defined(__LP64__) && defined(__clang__)
-    if ([object isKindOfClass:[WKBrowsingContextController class]])
+    if ([object isKindOfClass:[WKBrowsingContextController class]] || [object isKindOfClass:[WKWebProcessPlugInBrowserContextController class]])
         return WKBrowsingContextControllerType;
 #endif