Changeset 136885 in webkit


Ignore:
Timestamp:
Dec 6, 2012, 2:00:46 PM (12 years ago)
Author:
wangxianzhu@chromium.org
Message:

internals.settings.setEnableCompositingForFixedPosition() should be called before onload
​https://bugs.webkit.org/show_bug.cgi?id=104277

Fixed some tests that set enableCompositingForFixedPosition in onload handler which may not take effect because it is too late.
Leave the image mismatches to bug 96839.

Reviewed by Simon Fraser.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale-scroll.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/layer-creation/fixed-position-out-of-view.html:
  • platform/chromium/TestExpectations: Mark the original flaky image mismatch as constantly failure. Add one image mismatch caused by this change but because of incorrect baseline.
Location:
trunk/LayoutTests
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r136880 r136885  
     12012-12-06  Xianzhu Wang  <wangxianzhu@chromium.org>
     2
     3        internals.settings.setEnableCompositingForFixedPosition() should be called before onload
     4        https://bugs.webkit.org/show_bug.cgi?id=104277
     5
     6        Fixed some tests that set enableCompositingForFixedPosition in onload handler which may not take effect because it is too late.
     7        Leave the image mismatches to bug 96839.
     8
     9        Reviewed by Simon Fraser.
     10
     11        * compositing/geometry/fixed-position-composited-page-scale-down.html:
     12        * compositing/geometry/fixed-position-composited-page-scale-scroll.html:
     13        * compositing/geometry/fixed-position-composited-page-scale.html:
     14        * compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
     15        * compositing/geometry/fixed-position-iframe-composited-page-scale.html:
     16        * compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
     17        * compositing/geometry/fixed-position-transform-composited-page-scale.html:
     18        * compositing/layer-creation/fixed-position-out-of-view.html:
     19        * platform/chromium/TestExpectations: Mark the original flaky image mismatch as constantly failure. Add one image mismatch caused by this change but because of incorrect baseline.
     20
    1212012-12-06  Stephen White  <senorblanco@chromium.org>
    222

  • trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html

    r136055 r136885  
    1414</style>
    1515<script>
    16   function scale() {
    17     if (window.internals) {
    18       window.internals.settings.setEnableCompositingForFixedPosition(true);
    19       window.internals.setPageScaleFactor(0.5, 0, 0);
    20     }
    21     if (window.testRunner)
    22       testRunner.dumpAsText(true);
     16  if (window.internals) {
     17    window.internals.settings.setEnableCompositingForFixedPosition(true);
     18    window.internals.setPageScaleFactor(0.5, 0, 0);
    2319  }
     20  if (window.testRunner)
     21    testRunner.dumpAsText(true);
    2422</script>
    2523</head>
    26 <body onload="scale();" style="width:2000px;height:2000px;">
     24<body style="width:2000px;height:2000px;">
    2725<div class="fixed-no-z-index">TEST</div><br>
    2826<div class="fixed-with-z-index">TEST</div>

  • trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-scroll.html

    r136055 r136885  
    1515</style>
    1616<script>
    17   function scale() {
    18     if (window.internals) {
    19       window.internals.settings.setEnableCompositingForFixedPosition(true);
    20       window.internals.setPageScaleFactor(2, 0, 0);
    21     }
     17  if (window.internals) {
     18    window.internals.settings.setEnableCompositingForFixedPosition(true);
     19    window.internals.setPageScaleFactor(2, 0, 0);
     20  }
     21  function test() {
    2222    window.scrollTo(100,100);
    2323    if (window.testRunner)
    … …  
    2626</script>
    2727</head>
    28 <body onload="scale();" style="width:2000px;height:2000px;">
     28<body onload="test();" style="width:2000px;height:2000px;">
    2929<div class="fixed-no-z-index">This test should not hit an assertion in RenderGeometryMap in debug builds</div><br>
    3030<div class="fixed-with-z-index">This test should not hit an assertion in RenderGeometryMap in debug builds</div>

  • trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html

    r136055 r136885  
    1414</style>
    1515<script>
    16   function scale() {
    17     if (window.internals) {
    18       window.internals.settings.setEnableCompositingForFixedPosition(true);
    19       window.internals.setPageScaleFactor(2, 0, 0);
    20     }
    21     if (window.testRunner)
    22       testRunner.dumpAsText(true);
     16  if (window.internals) {
     17    window.internals.settings.setEnableCompositingForFixedPosition(true);
     18    window.internals.setPageScaleFactor(2, 0, 0);
    2319  }
     20  if (window.testRunner)
     21    testRunner.dumpAsText(true);
    2422</script>
    2523</head>
    26 <body onload="scale();" style="width:2000px;height:2000px;">
     24<body style="width:2000px;height:2000px;">
    2725<div class="fixed-no-z-index">TEST</div><br>
    2826<div class="fixed-with-z-index">TEST</div>

  • trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html

    r136055 r136885  
    1414</style>
    1515<script>
     16  if (window.internals) {
     17    window.internals.settings.setEnableCompositingForFixedPosition(true);
     18    window.internals.setPageScaleFactor(0.5, 0, 0);
     19  }
    1620  function test() {
    17     if (window.internals) {
    18       window.internals.settings.setEnableCompositingForFixedPosition(true);
    19       window.internals.setPageScaleFactor(0.5, 0, 0);
    20     }
    2121    if (window.testRunner)
    2222      testRunner.dumpAsText(true);

  • trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html

    r136055 r136885  
    1414</style>
    1515<script>
     16  if (window.internals) {
     17    window.internals.settings.setEnableCompositingForFixedPosition(true);
     18    window.internals.setPageScaleFactor(2, 0, 0);
     19  }
    1620  function test() {
    17     if (window.internals) {
    18       window.internals.settings.setEnableCompositingForFixedPosition(true);
    19       window.internals.setPageScaleFactor(2, 0, 0);
    20     }
    2121    if (window.testRunner)
    2222      testRunner.dumpAsText(true);

  • trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html

    r136055 r136885  
    1616</style>
    1717<script>
    18   function scale() {
    19     if (window.internals) {
    20       window.internals.settings.setEnableCompositingForFixedPosition(true);
    21       window.internals.setPageScaleFactor(0.5, 0, 0);
    22     }
    23     if (window.testRunner)
    24       testRunner.dumpAsText(true);
     18  if (window.internals) {
     19    window.internals.settings.setEnableCompositingForFixedPosition(true);
     20    window.internals.setPageScaleFactor(0.5, 0, 0);
    2521  }
     22  if (window.testRunner)
     23    testRunner.dumpAsText(true);
    2624</script>
    2725</head>
    28 <body onload="scale();" style="width:2000px;height:2000px;">
     26<body style="width:2000px;height:2000px;">
    2927<div class="fixed-no-z-index">TEST</div><br>
    3028<div class="fixed-with-z-index">TEST</div>

  • trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html

    r136055 r136885  
    1616</style>
    1717<script>
    18   function scale() {
    19     if (window.internals) {
    20       window.internals.settings.setEnableCompositingForFixedPosition(true);
    21       window.internals.setPageScaleFactor(2, 0, 0);
    22     }
    23     if (window.testRunner)
    24       testRunner.dumpAsText(true);
     18  if (window.internals) {
     19    window.internals.settings.setEnableCompositingForFixedPosition(true);
     20    window.internals.setPageScaleFactor(2, 0, 0);
    2521  }
     22  if (window.testRunner)
     23    testRunner.dumpAsText(true);
    2624</script>
    2725</head>
    28 <body onload="scale();" style="width:2000px;height:2000px;">
     26<body style="width:2000px;height:2000px;">
    2927<div class="fixed-no-z-index">TEST</div><br>
    3028<div class="fixed-with-z-index">TEST</div>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r136880 r136885  
    35733573webkit.org/b/89510 [ Win ] gamepad/gamepad-polling-access.html [ Pass Timeout ]
    35743574
    3575 webkit.org/b/96839 compositing/geometry/fixed-position-transform-composited-page-scale.html [ ImageOnlyFailure Pass ]
    3576 webkit.org/b/96839 platform/chromium/virtual/softwarecompositing/geometry/fixed-position-transform-composited-page-scale.html [ ImageOnlyFailure Pass ]
     3575webkit.org/b/96839 compositing/geometry/fixed-position-transform-composited-page-scale.html [ ImageOnlyFailure ]
     3576webkit.org/b/96839 platform/chromium/virtual/softwarecompositing/geometry/fixed-position-transform-composited-page-scale.html [ ImageOnlyFailure ]
     3577webkit.org/b/96839 compositing/geometry/fixed-position-transform-composited-page-scale-down.html [ ImageOnlyFailure ]
     3578webkit.org/b/96839 platform/chromium/virtual/softwarecompositing/geometry/fixed-position-transform-composited-page-scale-down.html [ ImageOnlyFailure ]
    35773579webkit.org/b/89702 compositing/scaling/tiled-layer-recursion.html [ ImageOnlyFailure Pass ]
    35783580webkit.org/b/89702 platform/chromium/virtual/softwarecompositing/scaling/tiled-layer-recursion.html [ ImageOnlyFailure Pass ]
Note: See TracChangeset for help on using the changeset viewer.