Changeset 136916 in webkit

Timestamp:

Dec 6, 2012, 6:30:17 PM (12 years ago)

Author:

ojan@chromium.org

Message:

Review page is super flakey now
​https://bugs.webkit.org/show_bug.cgi?id=104331

Committing without review since this is breaking the code review tool.

remove is only shipping in Chromium. Use jQuery's remove instead.

• PrettyPatch/PrettyPatch.rb:
• code-review.js:

Location:

trunk/Websites/bugs.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• PrettyPatch/PrettyPatch.rb (modified) (1 diff)
• code-review.js (modified) (2 diffs)

trunk/Websites/bugs.webkit.org/ChangeLog

@@ +1 @@
+2012-12-06  Ojan Vafai  <ojan@chromium.org>
+
+        Review page is super flakey now
+        https://bugs.webkit.org/show_bug.cgi?id=104331
+
+        Committing without review since this is breaking the code review tool.
+
+        remove is only shipping in Chromium. Use jQuery's remove instead.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2012-12-05  Ojan Vafai  <ojan@chromium.org>
 

trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb

@@ -507 +507 @@
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=45"></script>
+<script src="code-review.js?version=46"></script>
 </head>
 EOF

trunk/Websites/bugs.webkit.org/code-review.js

@@ -1161 +1161 @@
     classesToRemove.forEach(function(className) {
       forEachNode(fragment.querySelectorAll('.' + className), function(node) {
-        node.remove();
+        $(node).remove();
       });
     });
@@ -1189 +1189 @@
 
     setTimeout(function() {
-      container.remove();
+      $(container).remove();
       selection.removeAllRanges();
       selection.addRange(range);