Changeset 137215 in webkit

Timestamp:

Dec 10, 2012, 3:43:43 PM (12 years ago)

Author:

Simon Fraser

Message:

Don't unconditionally repaint compositing layers when their size changes
​https://bugs.webkit.org/show_bug.cgi?id=104461

Reviewed by Sam Weinig.

Source/WebCore:

RenderLayerBacking always repainted the entire compositing layer when its size
changed. This was done to fix repaint issues when outline widths changes, but
that issue is now solved by repainting in GraphicsLayer::setOffsetFromRenderer(),
add in r134628. I believe this is no longer necessary.

Always repainting when the size changes is terrible for the tile cache when
loading large documents, as all tiles repaint every time the document gets
longer.

Test: compositing/repaint/resize-repaint.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

Test that dumps repaint rects after adding content to a compositing layer.

• compositing/repaint/resize-repaint-expected.txt: Added.
• compositing/repaint/resize-repaint.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/repaint/resize-repaint-expected.txt (added)
• LayoutTests/compositing/repaint/resize-repaint.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-12-10  Simon Fraser  <simon.fraser@apple.com>
+
+        Don't unconditionally repaint compositing layers when their size changes
+        https://bugs.webkit.org/show_bug.cgi?id=104461
+
+        Reviewed by Sam Weinig.
+
+        Test that dumps repaint rects after adding content to a compositing layer.
+
+        * compositing/repaint/resize-repaint-expected.txt: Added.
+        * compositing/repaint/resize-repaint.html: Added.
+
 2012-12-10  Ojan Vafai  <ojan@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-10  Simon Fraser  <simon.fraser@apple.com>
+
+        Don't unconditionally repaint compositing layers when their size changes
+        https://bugs.webkit.org/show_bug.cgi?id=104461
+
+        Reviewed by Sam Weinig.
+
+        RenderLayerBacking always repainted the entire compositing layer when its size
+        changed. This was done to fix repaint issues when outline widths changes, but
+        that issue is now solved by repainting in GraphicsLayer::setOffsetFromRenderer(),
+        add in r134628. I believe this is no longer necessary.
+        
+        Always repainting when the size changes is terrible for the tile cache when
+        loading large documents, as all tiles repaint every time the document gets
+        longer.
+
+        Test: compositing/repaint/resize-repaint.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
 2012-12-10  Ojan Vafai  <ojan@chromium.org>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -632 +632 @@
     FloatSize oldSize = m_graphicsLayer->size();
     FloatSize newSize = relativeCompositingBounds.size();
-    if (oldSize != newSize) {
+    if (oldSize != newSize)
         m_graphicsLayer->setSize(newSize);
-        // A bounds change will almost always require redisplay. Usually that redisplay
-        // will happen because of a repaint elsewhere, but not always:
-        // e.g. see RenderView::setMaximalOutlineSize()
-        m_graphicsLayer->setNeedsDisplay();
-    }
 
     // If we have a layer that clips children, position it.