Changeset 138038 in webkit

Timestamp:

Dec 18, 2012, 10:32:21 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Tests that time out are not considered as failures.
​https://bugs.webkit.org/show_bug.cgi?id=105318

Patch by Alberto Garcia <​agarcia@igalia.com> on 2012-12-18
Reviewed by Martin Robinson.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests.commandComplete):
Consider log lines that end with TIMEOUT as errors.

• Scripts/run-gtk-tests:

(TestRunner.run_tests):
Consider timeouts as failures when returning the number of failed
tests.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• Scripts/run-gtk-tests (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -543 +543 @@
         incorrectLines = []
         for line in logText.splitlines():
-            if line.startswith('ERROR'):
+            if line.startswith('ERROR') or line.endswith('TIMEOUT\n'):
                 incorrectLines.append(line)
 

trunk/Tools/ChangeLog

@@ +1 @@
+2012-12-18  Alberto Garcia  <agarcia@igalia.com>
+
+        [GTK] Tests that time out are not considered as failures.
+        https://bugs.webkit.org/show_bug.cgi?id=105318
+
+        Reviewed by Martin Robinson.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+        (RunGtkAPITests.commandComplete):
+        Consider log lines that end with TIMEOUT as errors.
+
+        * Scripts/run-gtk-tests:
+        (TestRunner.run_tests):
+        Consider timeouts as failures when returning the number of failed
+        tests.
+
 2012-12-18  Pravin D  <pravin.d@samsung.com>
 

trunk/Tools/Scripts/run-gtk-tests

@@ -348 +348 @@
             sys.stdout.flush()
 
-        return len(failed_tests)
+        return len(failed_tests) + len(timed_out_tests)
 
 if __name__ == "__main__":