Changeset 138393 in webkit

Timestamp:

Dec 21, 2012, 11:38:28 AM (12 years ago)

Author:

kbr@google.com

Message:

Expose ArrayBufferView constructor on DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=105605

Reviewed by Sam Weinig.

Source/WebCore:

Update IDL to track recent spec change exposing ArrayBufferView
constructor on DOMWindow for instanceof checks. There are no
constructors exposed in the Web IDL, however, so calling it via
operator new throws TypeError.

Test (updated): fast/canvas/webgl/array-unit-tests.html

• html/canvas/ArrayBufferView.idl:

Removed OmitConstructor attribute.

• page/DOMWindow.idl:

Exposed ArrayBufferView constructor function attribute.

LayoutTests:

Updated test from Khronos repository.

• fast/canvas/webgl/array-unit-tests-expected.txt:
• fast/canvas/webgl/array-unit-tests.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/array-unit-tests.html (modified) (6 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/ArrayBufferView.idl (modified) (1 diff)
• Source/WebCore/page/DOMWindow.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-12-21  Kenneth Russell  <kbr@google.com>
+
+        Expose ArrayBufferView constructor on DOMWindow
+        https://bugs.webkit.org/show_bug.cgi?id=105605
+
+        Reviewed by Sam Weinig.
+
+        Updated test from Khronos repository.
+
+        * fast/canvas/webgl/array-unit-tests-expected.txt:
+        * fast/canvas/webgl/array-unit-tests.html:
+
 2012-12-21  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt

@@ -3 +3 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
+PASS testSlice
+test inheritance hierarchy of typed array views
+PASS ArrayBufferView does not have [NoInterfaceObject] extended attribute and should be defined
+PASS new Int8Array(1) instanceof ArrayBufferView is true
+PASS new Uint8Array(1) instanceof ArrayBufferView is true
+PASS new Uint8ClampedArray(1) instanceof ArrayBufferView is true
+PASS new Int16Array(1) instanceof ArrayBufferView is true
+PASS new Uint16Array(1) instanceof ArrayBufferView is true
+PASS new Int32Array(1) instanceof ArrayBufferView is true
+PASS new Uint32Array(1) instanceof ArrayBufferView is true
+PASS new Float32Array(1) instanceof ArrayBufferView is true
+PASS new Float64Array(1) instanceof ArrayBufferView is true
+PASS new DataView(new ArrayBuffer(8)) instanceof ArrayBufferView is true
+PASS new ArrayBufferView() threw TypeError
+PASS new Uint8ClampedArray(1) instanceof Uint8Array is true
 PASS test Float32Array SetAndGetPos10ToNeg10
 PASS test Float32Array ConstructWithArrayOfSignedValues

trunk/LayoutTests/fast/canvas/webgl/array-unit-tests.html

@@ -71 +71 @@
 
   try {
+    running('testSlice');
     var buffer = new ArrayBuffer(32);
     var array = new Int8Array(buffer);
@@ -103 +104 @@
     test("buffer.slice(-40, 16)", 0, 16);
     test("buffer.slice(-40, 40)", 0, 32);
+    pass();
   } catch (e) {
     fail(e);
@@ -219 +221 @@
 
   if (unsigned) {
-    sourceData = [0.6, 10.6];
+    sourceData = [0.6, 10.6, 0.2, 10.2, 10.5, 11.5];
     if (type === Uint8ClampedArray) {
-      expectedResults = [1, 11];
+      expectedResults = [1, 11, 0, 10, 10, 12];
     } else {
-      expectedResults = [0, 10];
+      expectedResults = [0, 10, 0, 10, 10, 11];
     }
   } else {
@@ -550 +552 @@
     } catch (e) {
         testPassed(text + " threw an exception");
+    }
+}
+
+function shouldThrowTypeError(func, text) {
+    var ok = false;
+    try {
+        func();
+    } catch (e) {
+        if (e instanceof TypeError) {
+            ok = true;
+        }
+    }
+    if (ok) {
+        testPassed(text + " threw TypeError");
+    } else {
+        testFailed(text + " should throw TypeError");
     }
 }
@@ -902 +920 @@
 }
 
+function testInheritanceHierarchy() {
+  debug('test inheritance hierarchy of typed array views');
+
+  try {
+    var foo = ArrayBufferView;
+    testPassed('ArrayBufferView does not have [NoInterfaceObject] extended attribute and should be defined');
+
+    shouldBe('new Int8Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Uint8Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Uint8ClampedArray(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Int16Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Uint16Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Int32Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Uint32Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Float32Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new Float64Array(1) instanceof ArrayBufferView', 'true');
+    shouldBe('new DataView(new ArrayBuffer(8)) instanceof ArrayBufferView', 'true');
+
+    shouldThrowTypeError(function() { new ArrayBufferView() }, "new ArrayBufferView()");
+  } catch (e) {
+    testFailed('ArrayBufferView does not have [NoInterfaceObject] extended attribute but was not defined');
+  }
+
+  // There is currently only one kind of view that inherits from another
+  shouldBe('new Uint8ClampedArray(1) instanceof Uint8Array', 'true');
+}
+
+
 //
 // Test driver
@@ -910 +956 @@
 
   testSlice();
+  testInheritanceHierarchy();
 
   // The "name" attribute is a concession to browsers which don't

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-21  Kenneth Russell  <kbr@google.com>
+
+        Expose ArrayBufferView constructor on DOMWindow
+        https://bugs.webkit.org/show_bug.cgi?id=105605
+
+        Reviewed by Sam Weinig.
+
+        Update IDL to track recent spec change exposing ArrayBufferView
+        constructor on DOMWindow for instanceof checks. There are no
+        constructors exposed in the Web IDL, however, so calling it via
+        operator new throws TypeError.
+
+        Test (updated): fast/canvas/webgl/array-unit-tests.html
+
+        * html/canvas/ArrayBufferView.idl:
+            Removed OmitConstructor attribute.
+        * page/DOMWindow.idl:
+            Exposed ArrayBufferView constructor function attribute.
+
 2012-12-21  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/html/canvas/ArrayBufferView.idl

@@ -26 +26 @@
 [
     CustomToJSObject,
-    JSNoStaticTables,
-    OmitConstructor
+    JSNoStaticTables
 ] interface ArrayBufferView {
     readonly attribute ArrayBuffer buffer;

trunk/Source/WebCore/page/DOMWindow.idl

@@ -530 +530 @@
 
     attribute ArrayBufferConstructor ArrayBuffer; // Usable with new operator
+    attribute ArrayBufferViewConstructor ArrayBufferView;
     attribute Int8ArrayConstructor Int8Array; // Usable with new operator
     attribute Uint8ArrayConstructor Uint8Array; // Usable with new operator