Changeset 139017 in webkit

Timestamp:

Jan 7, 2013, 5:08:12 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Don't use double tap zoom if minimum and maximum page scale is the same
​https://bugs.webkit.org/show_bug.cgi?id=106272

Patch by Yusuf Ozuysal <​yusufo@google.com> on 2013-01-07
Reviewed by James Robinson.

We should only try to computed relevant scale and scrollOffset and start the animation
if the page is zoomable. This now creates an undesired animation for mobile pages which
are not zoomable.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebViewImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-01-07  Yusuf Ozuysal  <yusufo@google.com>
+
+        Don't use double tap zoom if minimum and maximum page scale is the same
+        https://bugs.webkit.org/show_bug.cgi?id=106272
+
+        Reviewed by James Robinson.
+
+        We should only try to computed relevant scale and scrollOffset and start the animation
+        if the page is zoomable. This now creates an undesired animation for mobile pages which
+        are not zoomable.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::handleGestureEvent):
+
 2013-01-07  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -776 +776 @@
     }
     case WebInputEvent::GestureDoubleTap:
-        if (m_webSettings->doubleTapToZoomEnabled()) {
+        if (m_webSettings->doubleTapToZoomEnabled() && m_minimumPageScaleFactor != m_maximumPageScaleFactor) {
             m_client->cancelScheduledContentIntents();
             animateZoomAroundPoint(WebPoint(event.x, event.y), DoubleTap);