Changeset 139087 in webkit

Timestamp:

Jan 8, 2013, 11:28:34 AM (13 years ago)

Author:

peter@chromium.org

Message:

[Chromium] Modify Android's user agent CSS to not set a border-radius on select elements
​https://bugs.webkit.org/show_bug.cgi?id=106327

Reviewed by Adam Barth.

Android's user agent CSS overrides the style applied to <select>
elements with a @size or @multiple attribute, and then applies
(among other things) a border-radius of 5 pixels. While select
elements with a larger size or multiple selection should appear
as drop-down boxes for now, setting the border radius causes
Chromium to skip rendering the background and border, making
them hard to read when the page relies on the default styling.

This is covered by existing pixel tests.

• css/themeChromiumAndroid.css:

(select[size][multiple]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/themeChromiumAndroid.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-08  Peter Beverloo  <peter@chromium.org>
+
+        [Chromium] Modify Android's user agent CSS to not set a border-radius on select elements
+        https://bugs.webkit.org/show_bug.cgi?id=106327
+
+        Reviewed by Adam Barth.
+
+        Android's user agent CSS overrides the style applied to <select>
+        elements with a @size or @multiple attribute, and then applies
+        (among other things) a border-radius of 5 pixels. While select
+        elements with a larger size or multiple selection should appear
+        as drop-down boxes for now, setting the border radius causes
+        Chromium to skip rendering the background and border, making
+        them hard to read when the page relies on the default styling.
+
+        This is covered by existing pixel tests.
+
+        * css/themeChromiumAndroid.css:
+        (select[size][multiple]):
+
 2013-01-08  Mike West  <mkwst@chromium.org>
 

trunk/Source/WebCore/css/themeChromiumAndroid.css

@@ -37 +37 @@
     -webkit-box-align: center;
     border: 1px solid;
-    border-radius: 5px;
+    border-radius: initial;
     white-space: pre;
 }