Changeset 139091 in webkit

Timestamp:

Jan 8, 2013, 11:52:53 AM (12 years ago)

Author:

Chris Fleizach

Message:

AX: native popup buttons should not use textUnderElement for their title
​https://bugs.webkit.org/show_bug.cgi?id=106349

Reviewed by Ryosuke Niwa.

Native popup buttons (<select> elements) were calculating its title based on the text
under the element. When Bug 103794 introduced a more complete way of getting render text,
it causes popup buttons to start returning a title.
The fix is that we should not be calculating a title for a native popup button from its children.

Existing tests cover this functionality. This will fix a failing test.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityNodeObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-08  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: native popup buttons should not use textUnderElement for their title
+        https://bugs.webkit.org/show_bug.cgi?id=106349
+
+        Reviewed by Ryosuke Niwa.
+
+        Native popup buttons (<select> elements) were calculating its title based on the text
+        under the element. When Bug 103794 introduced a more complete way of getting render text,
+        it causes popup buttons to start returning a title.
+        The fix is that we should not be calculating a title for a native popup button from its children.
+
+        Existing tests cover this functionality. This will fix a failing test.
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::visibleText):
+
 2013-01-08  Ojan Vafai  <ojan@chromium.org>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -1193 +1193 @@
     switch (roleValue()) {
     case PopUpButtonRole:
+        // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue().
+        if (node->hasTagName(selectTag))
+            break;
     case ButtonRole:
     case ToggleButtonRole: