Changeset 139221 in webkit


Ignore:
Timestamp:
Jan 9, 2013, 12:24:03 PM (12 years ago)
Author:
ojan@chromium.org
Message:

fast/forms/min-content-form-controls.html fails on some platforms
​https://bugs.webkit.org/show_bug.cgi?id=106482

Reviewed by Eric Seidel.

The text dump for some form controls (menulists?) has different whitespace
output on different platforms. Remove the form controls to avoid adding
platform-specific expectations for this test.

  • fast/forms/min-content-form-controls-expected.txt:
  • fast/forms/min-content-form-controls.html:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r139219 r139221  
     12013-01-09  Ojan Vafai  <ojan@chromium.org>
     2
     3        fast/forms/min-content-form-controls.html fails on some platforms
     4        https://bugs.webkit.org/show_bug.cgi?id=106482
     5
     6        Reviewed by Eric Seidel.
     7
     8        The text dump for some form controls (menulists?) has different whitespace
     9        output on different platforms. Remove the form controls to avoid adding
     10        platform-specific expectations for this test.
     11
     12        * fast/forms/min-content-form-controls-expected.txt:
     13        * fast/forms/min-content-form-controls.html:
     14        * platform/mac/TestExpectations:
     15
    1162013-01-09  Michael Pruett  <michael@68k.org>
    217

  • trunk/LayoutTests/fast/forms/min-content-form-controls-expected.txt

    r139216 r139221  
    99The form controls of the same type below should be the same width.
    1010
    11              
     11

  • trunk/LayoutTests/fast/forms/min-content-form-controls.html

    r139216 r139221  
    3232ids.forEach(function(id) {
    3333    shouldBe('document.getElementById("' + id + '-a").offsetWidth', 'document.getElementById("' + id + '-b").offsetWidth');
    34 })
     34});
     35
     36function remove(id) {
     37    var node = document.getElementById(id);
     38    node.parentNode.removeChild(node);
     39}
     40
     41if (window.testRunner) {
     42    // Remove these elements since some of the text dumps are different platforms.
     43    ids.forEach(function(id) {
     44        remove(id + '-a');
     45        remove(id + '-b');
     46    });
     47}
    3548</script>
    3649<script src="../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/platform/mac/TestExpectations

    r139216 r139221  
    12451245webkit.org/b/105932 [ MountainLion Debug ] http/tests/inspector/resource-har-pages.html [ Crash ]
    12461246
    1247 # Need to see this run on the bots to see what's wrong. The code change in
    1248 # https://bugs.webkit.org/show_bug.cgi?id=106389 is only touching cross-platform code.
    1249 Bug(ojan) fast/forms/min-content-form-controls.html [ Failure ]
    1250 
    12511247webkit.org/b/105986 [ Debug ] transitions/hang-with-bad-transition-list.html [ Pass Crash ]
    12521248webkit.org/b/105986 [ Debug ] svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html [ Pass Crash ]
Note: See TracChangeset for help on using the changeset viewer.