Changeset 139939 in webkit

Timestamp:

Jan 16, 2013, 5:21:20 PM (14 years ago)

Author:

esprehn@chromium.org

Message:

Cursor stops blinking after clicking on scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=106470

Reviewed by Ojan Vafai.

Restore the caret blinking when doing a mouseup on a
scrollbar so scrolling a textarea doesn't cause the
caret to freeze.

No new tests, there doesn't seem to be any way to test
cursor blinking.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/EventHandler.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Elliott Sprehn  <esprehn@chromium.org>
+
+        Cursor stops blinking after clicking on scrollbar
+        https://bugs.webkit.org/show_bug.cgi?id=106470
+
+        Reviewed by Ojan Vafai.
+
+        Restore the caret blinking when doing a mouseup on a
+        scrollbar so scrolling a textarea doesn't cause the
+        caret to freeze.
+
+        No new tests, there doesn't seem to be any way to test
+        cursor blinking.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::handleMouseReleaseEvent):
+        (WebCore::EventHandler::handleMouseDoubleClickEvent):
+
 2013-01-16  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/page/EventHandler.cpp

@@ -889 +889 @@
     // Used to prevent mouseMoveEvent from initiating a drag before
     // the mouse is pressed again.
-    m_frame->selection()->setCaretBlinkingSuspended(false);
     m_mousePressed = false;
     m_capturesDragging = false;
@@ -1554 +1553 @@
     RefPtr<FrameView> protector(m_frame->view());
 
+    m_frame->selection()->setCaretBlinkingSuspended(false);
+
     UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
 
@@ -1761 +1762 @@
 {
     RefPtr<FrameView> protector(m_frame->view());
+
+    m_frame->selection()->setCaretBlinkingSuspended(false);
 
 #if ENABLE(TOUCH_EVENTS)