Changeset 140458 in webkit

Timestamp:

Jan 22, 2013, 1:23:41 PM (14 years ago)

Author:

zandobersek@gmail.com

Message:

Prettify the output of the override-feature-defines script
​https://bugs.webkit.org/show_bug.cgi?id=106542

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2013-01-22
Reviewed by Martin Robinson.

The output now clearly lists the feature defines being overridden
along with the default and overriding values for each feature define.

• gtk/override-feature-defines:

(adjust_feature_defines_makefile):
(adjust_feature_defines_makefile.override_feature_define):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• gtk/override-feature-defines (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
+
+        Prettify the output of the override-feature-defines script
+        https://bugs.webkit.org/show_bug.cgi?id=106542
+
+        Reviewed by Martin Robinson.
+
+        The output now clearly lists the feature defines being overridden
+        along with the default and overriding values for each feature define.
+
+        * gtk/override-feature-defines:
+        (adjust_feature_defines_makefile):
+        (adjust_feature_defines_makefile.override_feature_define):
+
 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Tools/gtk/override-feature-defines

@@ -16 +16 @@
         feature_defines_makefile = f.read()
 
-    overriden_feature_defines = []
+    overridden_feature_defines = {}
     def override_feature_define(match):
-        matched_feature_define = match.group('feature')
-        if matched_feature_define not in feature_defines_overriding:
+        feature_define = match.group('feature')
+        if feature_define not in feature_defines_overriding:
             return match.string[match.start():match.end()]
 
-        if int(match.group('default_value')) is not feature_defines_overriding[matched_feature_define]:
-            overriden_feature_defines.append(matched_feature_define)
-        return "%s=%d" % (matched_feature_define, feature_defines_overriding[matched_feature_define])
+        default_value = int(match.group('default_value'))
+        overriding_value = feature_defines_overriding[feature_define]
+        if default_value is not overriding_value:
+            overridden_feature_defines[feature_define] = default_value, overriding_value
+        return "%s=%d" % (feature_define, overriding_value)
 
     feature_defines_makefile = re.sub(r"(?P<feature>(?:ENABLE_)\w+)=(?P<default_value>0|1)", override_feature_define, feature_defines_makefile)
@@ -30 +32 @@
         f.write(feature_defines_makefile)
 
-    if overriden_feature_defines:
-        print("The following feature defines were overriden:\n{0}".format(', '.join(overriden_feature_defines)))
+    if overridden_feature_defines:
+        print("The following feature defines were overriden:")
+        for feature, values in iter(overridden_feature_defines.items()):
+            print("\t{0}: {1} => {2}".format(feature, *values))
 
 def override_feature_defines(build_dir):