Changeset 140460 in webkit

Timestamp:

Jan 22, 2013, 1:27:13 PM (14 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK] Enable CSS Image Orientation feature
​https://bugs.webkit.org/show_bug.cgi?id=99040

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2013-01-22
Reviewed by Martin Robinson.

Tools:

Enable the CSS Image Orientation feature in the development
builds of the GTK port. The feature is still disabled in the release
builds.

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove the general expectation, replacing it with a failure expectation
for the test that's failing due to whitespace problems in the cssText attribute
value after the image orientation attribute is set.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitperl/FeatureList.pm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Enable CSS Image Orientation feature
+        https://bugs.webkit.org/show_bug.cgi?id=99040
+
+        Reviewed by Martin Robinson.
+
+        Remove the general expectation, replacing it with a failure expectation
+        for the test that's failing due to whitespace problems in the cssText attribute
+        value after the image orientation attribute is set.
+
+        * platform/gtk/TestExpectations:
+
 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -364 +364 @@
 webkit.org/b/99057 fast/css/variables [ Skip ]
 webkit.org/b/99057 inspector/styles/variables [ Skip ]
-
-# CSS image-orientation is not yet enabled.
-webkit.org/b/99040 fast/css/image-orientation [ Failure ]
 
 # No CORS support for media elements is implemented yet.
@@ -1386 +1383 @@
 webkit.org/b/105574 fast/spatial-navigation/snav-div-overflow-scrol-hidden.html [ Failure ]
 
+webkit.org/b/106563 fast/css/image-orientation/image-orientation.html [ Failure ]
+
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of Tests failing

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Enable CSS Image Orientation feature
+        https://bugs.webkit.org/show_bug.cgi?id=99040
+
+        Reviewed by Martin Robinson.
+
+        Enable the CSS Image Orientation feature in the development
+        builds of the GTK port. The feature is still disabled in the release
+        builds.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
 

trunk/Tools/Scripts/webkitperl/FeatureList.pm

@@ -199 +199 @@
 
     { option => "css-image-orientation", desc => "Toggle CSS image-orientation support",
-      define => "ENABLE_CSS_IMAGE_ORIENTATION", default => 0, value => \$cssImageOrientationSupport },
+      define => "ENABLE_CSS_IMAGE_ORIENTATION", default => isGtk(), value => \$cssImageOrientationSupport },
 
     { option => "css-image-resolution", desc => "Toggle CSS image-resolution support",