Changeset 140501 in webkit

Timestamp:

Jan 22, 2013, 8:21:04 PM (14 years ago)

Author:

tkent@chromium.org

Message:

[Chromium] Fix calendar-picker-key-operations.html
​https://bugs.webkit.org/show_bug.cgi?id=101408

Reviewed by Kentaro Hara.

• platform/chromium/TestExpectations:
• platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

We need to apply the waitUntilClosing idiom because picker closing
operation is asynchronous.

• platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:

Fix a failure.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt (modified) (1 diff)
• platform/chromium/TestExpectations (modified) (1 diff)
• platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-22  Kent Tamura  <tkent@chromium.org>
+
+        [Chromium] Fix calendar-picker-key-operations.html
+        https://bugs.webkit.org/show_bug.cgi?id=101408
+
+        Reviewed by Kentaro Hara.
+
+        * platform/chromium/TestExpectations:
+        * platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
+        We need to apply the waitUntilClosing idiom because picker closing
+        operation is asynchronous.
+        * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
+        Fix a failure.
+
 2013-01-22  Yoshifumi Inoue  <yosin@chromium.org>
 

trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt

@@ -52 +52 @@
 PASS focusedElement() is ".year-month-button[value=<<]"
 PASS focusedElement() is ".clear-button[value=<<CalendarClear>>]"
-FAIL document.getElementById("mock-page-popup") should be null. Was [object HTMLIFrameElement].
+PASS document.getElementById("mock-page-popup") is null
 PASS document.getElementById("date").value is "1999-12-26"
 PASS F4 opened picker.

trunk/LayoutTests/platform/chromium/TestExpectations

@@ -4101 +4101 @@
 webkit.org/b/101377 [ Linux MountainLion ] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html [ Failure ImageOnlyFailure Pass Crash ]
 
-webkit.org/b/101408 [ Mac ] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure ]
 webkit.org/b/101408 platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html [ Failure Pass ]
 

trunk/LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html

@@ -112 +112 @@
 
     eventSender.keyDown('\x1B');
+    waitUntilClosing(test2AfterClosing);
+}
+
+function test2AfterClosing() {
     shouldBeNull('document.getElementById("mock-page-popup")');
     shouldBe('document.getElementById("date").value', '"1999-12-26"');