Changeset 140707 in webkit

Timestamp:

Jan 24, 2013, 12:24:56 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Implement :past pseudo class for the WebVTT ::cue pseudo element
​https://bugs.webkit.org/show_bug.cgi?id=105482

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-24
Reviewed by Eric Carlson.

Source/WebCore:

It is good to have a designated pseudo class for this, though same could
be achieved by using a combination of ::cue and ::cue(:future).
Tests also check that nested timestamps work properly.

Test: media/track/track-css-matching-timestamps.html

• css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

• css/CSSSelector.h:
• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

LayoutTests:

• media/track/captions-webvtt/styling-timestamps.vtt: Added.
• media/track/track-css-matching-timestamps-expected.txt: Added.
• media/track/track-css-matching-timestamps.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/track/captions-webvtt/styling-timestamps.vtt (added)
• LayoutTests/media/track/track-css-matching-timestamps-expected.txt (added)
• LayoutTests/media/track/track-css-matching-timestamps.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSSelector.cpp (modified) (4 diffs)
• Source/WebCore/css/CSSSelector.h (modified) (1 diff)
• Source/WebCore/css/SelectorChecker.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-24  Dima Gorbik  <dgorbik@apple.com>
+
+        Implement :past pseudo class for the WebVTT ::cue pseudo element
+        https://bugs.webkit.org/show_bug.cgi?id=105482
+
+        Reviewed by Eric Carlson.
+
+        * media/track/captions-webvtt/styling-timestamps.vtt: Added.
+        * media/track/track-css-matching-timestamps-expected.txt: Added.
+        * media/track/track-css-matching-timestamps.html: Added.
+
 2013-01-24  Max Vujovic  <mvujovic@adobe.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-24  Dima Gorbik  <dgorbik@apple.com>
+
+        Implement :past pseudo class for the WebVTT ::cue pseudo element
+        https://bugs.webkit.org/show_bug.cgi?id=105482
+
+        Reviewed by Eric Carlson.
+
+        It is good to have a designated pseudo class for this, though same could
+        be achieved by using a combination of ::cue and ::cue(:future).
+        Tests also check that nested timestamps work properly.
+
+        Test: media/track/track-css-matching-timestamps.html
+
+        * css/CSSSelector.cpp:
+        (WebCore::CSSSelector::pseudoId):
+        (WebCore::nameToPseudoTypeMap):
+        (WebCore::CSSSelector::extractPseudoType):
+        * css/CSSSelector.h:
+        * css/SelectorChecker.cpp:
+        (WebCore::SelectorChecker::checkOne):
+
 2013-01-23  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/css/CSSSelector.cpp

@@ -239 +239 @@
     case PseudoCue:
     case PseudoFutureCue:
+    case PseudoPastCue:
 #endif
 #if ENABLE(IFRAME_SEAMLESS)
@@ -328 +329 @@
     DEFINE_STATIC_LOCAL(AtomicString, cue, ("cue(", AtomicString::ConstructFromLiteral));
     DEFINE_STATIC_LOCAL(AtomicString, futureCue, ("future", AtomicString::ConstructFromLiteral));
+    DEFINE_STATIC_LOCAL(AtomicString, pastCue, ("past", AtomicString::ConstructFromLiteral));
 #endif
 #if ENABLE(IFRAME_SEAMLESS)
@@ -410 +412 @@
         nameToPseudoType->set(cue.impl(), CSSSelector::PseudoCue);
         nameToPseudoType->set(futureCue.impl(), CSSSelector::PseudoFutureCue);
+        nameToPseudoType->set(pastCue.impl(), CSSSelector::PseudoPastCue);
 #endif
 #if ENABLE(IFRAME_SEAMLESS)
@@ -540 +543 @@
 #if ENABLE(VIDEO_TRACK)
     case PseudoFutureCue:
+    case PseudoPastCue:
 #endif
         break;

trunk/Source/WebCore/css/CSSSelector.h

@@ -161 +161 @@
             PseudoCue,
             PseudoFutureCue,
+            PseudoPastCue,
 #endif
 #if ENABLE(IFRAME_SEAMLESS)

trunk/Source/WebCore/css/SelectorChecker.cpp

@@ -871 +871 @@
         case CSSSelector::PseudoFutureCue:
             return (element->isWebVTTElement() && toWebVTTElement(element)->webVTTNodeType() == WebVTTNodeTypeFuture);
+        case CSSSelector::PseudoPastCue:
+            return (element->isWebVTTElement() && toWebVTTElement(element)->webVTTNodeType() == WebVTTNodeTypePast);
 #endif