Changeset 141007 in webkit

Timestamp:

Jan 28, 2013, 2:06:01 PM (12 years ago)

Author:

tony@chromium.org

Message:

"clang: warning: not using the clang compiler for C++ inputs" due to hard-coding of /usr/bin/clang in WebCore.gyp
​https://bugs.webkit.org/show_bug.cgi?id=108089

Reviewed by Ojan Vafai.

Use gcc since older versions of clang (with Xcode 3.2) warn that they are going to use gcc anyway.
These warnings are showing up on the main Chromium waterfall too:
​http://build.chromium.org/p/chromium/builders/Mac/builds/19113/steps/compile/logs/stdio

No new tests, this is a build change.

• WebCore.gyp/WebCore.gyp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-28  Tony Chang  <tony@chromium.org>
+
+        "clang: warning: not using the clang compiler for C++ inputs" due to hard-coding of /usr/bin/clang in WebCore.gyp
+        https://bugs.webkit.org/show_bug.cgi?id=108089
+
+        Reviewed by Ojan Vafai.
+
+        Use gcc since older versions of clang (with Xcode 3.2) warn that they are going to use gcc anyway.
+        These warnings are showing up on the main Chromium waterfall too:
+        http://build.chromium.org/p/chromium/builders/Mac/builds/19113/steps/compile/logs/stdio
+
+        No new tests, this is a build change.
+
+        * WebCore.gyp/WebCore.gyp:
+
 2013-01-28  Elliott Sprehn  <esprehn@chromium.org>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -241 +241 @@
         'bison_exe': 'bison',
 
-        'conditions': [
-          # We specify a preprocess so it happens locally and won't get distributed to goma.
-          ['OS=="mac" or OS=="ios"', {
-            'preprocessor': '--preprocessor "/usr/bin/clang -E -P -x c++"'
-          },{
-            'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"'
-          }]
-        ],
+        # We specify a preprocess so it happens locally and won't get distributed to goma.
+        # FIXME: /usr/bin/gcc won't exist on OSX forever. We want to use /usr/bin/clang once we require Xcode 4.x.
+        'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"'
       }],
       ['use_x11==1 or OS=="android"', {