Changeset 141009 in webkit

Timestamp:

Jan 28, 2013, 2:28:21 PM (13 years ago)

Author:

jchaffraix@webkit.org

Message:

Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code
​https://bugs.webkit.org/show_bug.cgi?id=108084

Reviewed by Dean Jackson.

This is a blind fix based on the code and Chromium's stack-traces.

Unfortunately no new test as I couldn't get a local reproduction.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
Added a missing NULL-check: the previous 'while' finish if |lineBox|
is NULL and we don't want to crash in this case.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockLineLayout.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-28  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code
+        https://bugs.webkit.org/show_bug.cgi?id=108084
+
+        Reviewed by Dean Jackson.
+
+        This is a blind fix based on the code and Chromium's stack-traces.
+
+        Unfortunately no new test as I couldn't get a local reproduction.
+
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlock::layoutRunsAndFloatsInRange):
+        Added a missing NULL-check: the previous 'while' finish if |lineBox|
+        is NULL and we don't want to crash in this case.
+
 2013-01-28  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -1668 +1668 @@
 
         // If there were no breaks in the block, we didn't create any widows.
-        if (!lineBox->isFirstAfterPageBreak() || lineBox == firstLineInBlock)
+        if (!lineBox || !lineBox->isFirstAfterPageBreak() || lineBox == firstLineInBlock)
             return;