Changeset 142051 in webkit


Ignore:
Timestamp:
Feb 6, 2013, 4:28:13 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Context's currentPath should check for passed type
​https://bugs.webkit.org/show_bug.cgi?id=109097

Patch by Dirk Schulze <​dschulze@adobe.com> on 2013-02-06
Reviewed by Dean Jackson.

Source/WebCore:

Add check for passed pointer and return earlier.

Test: fast/canvas/canvas-currentPath-crash.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setCurrentPath):

LayoutTests:

Add checks with different data types as value for canvas.currentPath.

  • fast/canvas/canvas-currentPath-crash-expected.txt: Added.
  • fast/canvas/canvas-currentPath-crash.html: Added.
  • fast/canvas/script-tests/canvas-currentPath-crash.js: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
Location:
trunk
Files:
3 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r142050 r142051  
     12013-02-06  Dirk Schulze  <dschulze@adobe.com>
     2
     3        Context's currentPath should check for passed type
     4        https://bugs.webkit.org/show_bug.cgi?id=109097
     5
     6        Reviewed by Dean Jackson.
     7
     8        Add checks with different data types as value for canvas.currentPath.
     9
     10        * fast/canvas/canvas-currentPath-crash-expected.txt: Added.
     11        * fast/canvas/canvas-currentPath-crash.html: Added.
     12        * fast/canvas/script-tests/canvas-currentPath-crash.js: Added.
     13        * platform/chromium/TestExpectations:
     14        * platform/efl/TestExpectations:
     15        * platform/gtk/TestExpectations:
     16        * platform/mac/TestExpectations:
     17        * platform/qt/TestExpectations:
     18
    1192013-02-06  Stephen Chenney  <schenney@chromium.org>
    220

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r142018 r142051  
    42324232webkit.org/b/107508 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html [ ImageOnlyFailure Pass ]
    42334233
     4234# Rebaseline after currentPath
     4235webkit.org/b/108246 fast/canvas/canvas-currentPath.html [ Failure ]
     4236webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath.html [ Failure ]
     4237webkit.org/b/108246 fast/canvas/canvas-currentPath-crash.html [ Failure ]
     4238webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath-crash.html [ Failure ]
     4239
    42344240# Broken by Skia flag changes in r139445
    42354241crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]

  • trunk/LayoutTests/platform/efl/TestExpectations

    r141714 r142051  
    18241824webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
    18251825webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
     1826webkit.org/b/108508 fast/canvas/canvas-currentPath-crash.html [ Failure ]
    18261827
    18271828# Test fails on JSC platforms due to GC timing problems

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r142034 r142051  
    13921392webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
    13931393webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
     1394webkit.org/b/108508 fast/canvas/canvas-currentPath-crash.html [ Failure ]
    13941395
    13951396# volume is reset when mediaelement.src is modified

  • trunk/LayoutTests/platform/mac/TestExpectations

    r142024 r142051  
    148148fast/canvas/canvas-currentPath.html
    149149fast/canvas/canvas-path-constructors.html
     150fast/canvas/canvas-currentPath-crash.html
    150151
    151152# This port doesn't support DeviceMotion or DeviceOrientation.

  • trunk/LayoutTests/platform/qt/TestExpectations

    r141993 r142051  
    9494fast/canvas/canvas-currentPath.html
    9595fast/canvas/canvas-path-constructors.html
     96fast/canvas/canvas-currentPath-crash.html
    9697
    9798# ENABLE(INPUT_SPEECH) is disabled.

  • trunk/Source/WebCore/ChangeLog

    r142049 r142051  
     12013-02-06  Dirk Schulze  <dschulze@adobe.com>
     2
     3        Context's currentPath should check for passed type
     4        https://bugs.webkit.org/show_bug.cgi?id=109097
     5
     6        Reviewed by Dean Jackson.
     7
     8        Add check for passed pointer and return earlier.
     9
     10        Test: fast/canvas/canvas-currentPath-crash.html
     11
     12        * html/canvas/CanvasRenderingContext2D.cpp:
     13        (WebCore::CanvasRenderingContext2D::setCurrentPath):
     14
    1152013-02-06  Rafael Weinstein  <rafaelw@chromium.org>
    216

  • trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp

    r141612 r142051  
    868868void CanvasRenderingContext2D::setCurrentPath(DOMPath* path)
    869869{
     870    if (!path)
     871        return;
    870872    m_path = path->path();
    871873}
Note: See TracChangeset for help on using the changeset viewer.