Changeset 143379 in webkit

Timestamp:

Feb 19, 2013, 1:48:33 PM (12 years ago)

Author:

pdr@google.com

Message:

Merge 141645

Prevent skipped repaints for children of inner SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=108429

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.

I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.

Test: svg/repaint/svgsvgelement-repaint-children.html

• rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.

(WebCore::RenderSVGViewportContainer::calculateLocalTransform):

This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().

LayoutTests:

Need to update expectations for a single file (just a 1px difference).

• platform/chromium/TestExpectations:
• platform/efl/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt/TestExpectations:
• platform/win/TestExpectations:
• svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
• svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
• svg/repaint/svgsvgelement-repaint-children.html: Added.

TBR=​pdr@google.com

Location:

branches/chromium/1364

Files:

• LayoutTests/platform/chromium/TestExpectations (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• LayoutTests/platform/qt/TestExpectations (modified) (1 diff)
• LayoutTests/platform/win/TestExpectations (modified) (1 diff)
• LayoutTests/svg/repaint/svgsvgelement-repaint-children-expected.png (copied) (copied from trunk/LayoutTests/svg/repaint/svgsvgelement-repaint-children-expected.png )
• LayoutTests/svg/repaint/svgsvgelement-repaint-children-expected.txt (copied) (copied from trunk/LayoutTests/svg/repaint/svgsvgelement-repaint-children-expected.txt )
• LayoutTests/svg/repaint/svgsvgelement-repaint-children.html (copied) (copied from trunk/LayoutTests/svg/repaint/svgsvgelement-repaint-children.html )
• Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp (modified) (2 diffs)

branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations

@@ -3620 +3620 @@
 webkit.org/b/94242 [ Android Debug ] media/track/track-cues-sorted-before-dispatch.html [ Crash Pass Timeout ]
 
+# Needs a rebaseline after WK108429 lands.
+webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ]
+webkit.org/b/108429 svg/repaint/svgsvgelement-repaint-children.html [ Pass Failure ]
+
 # Chromium still has the CC toggle button, not the menu of tracks.
 webkit.org/b/101670 media/video-controls-captions-trackmenu.html [ Skip ]

branches/chromium/1364/LayoutTests/platform/mac/TestExpectations

@@ -1156 +1156 @@
 webkit.org/b/104595 fast/css/empty-generated-content.html [ Failure ]
 
+# Needs a rebaseline after WK108429 lands.
+webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ]
+
 webkit.org/b/93247 [ Debug ] fast/lists/list-marker-remove-crash.html [ Crash ]
 

branches/chromium/1364/LayoutTests/platform/qt/TestExpectations

@@ -2337 +2337 @@
 webkit.org/b/99870 svg/custom/pattern-scaling.svg [ Pass ImageOnlyFailure Missing ]
 
+# Needs a rebaseline after WK108429 lands.
+webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ]
+
 # Disable webaudio codec tests, including proprietary codecs.
 webkit.org/b/88794 webaudio/codec-tests

branches/chromium/1364/LayoutTests/platform/win/TestExpectations

@@ -2035 +2035 @@
 fast/forms/time-multiple-fields
 fast/forms/week-multiple-fields
+
+# Needs a rebaseline after WK108429 lands.
+svg/custom/text-ctm.svg
 
 # Require rebaseline after https://bugs.webkit.org/show_bug.cgi?id=84286

branches/chromium/1364/Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp

@@ -115 +115 @@
 
     if (oldViewport != m_viewport) {
-        m_didTransformToRootUpdate = true;
         setNeedsBoundariesUpdate();
         setNeedsTransformUpdate();
@@ -123 +122 @@
 bool RenderSVGViewportContainer::calculateLocalTransform() 
 {
+    m_didTransformToRootUpdate = m_needsTransformUpdate || SVGRenderSupport::transformToRootChanged(parent());
     if (!m_needsTransformUpdate)
         return false;