Changeset 143505 in webkit


Ignore:
Timestamp:
Feb 20, 2013, 2:14:04 PM (12 years ago)
Author:
krit@webkit.org
Message:

Enable CANVAS_PATH flag
​https://bugs.webkit.org/show_bug.cgi?id=108508

Reviewed by Simon Fraser.

Enable CANVAS_PATH flag on trunk.

.:

Existing tests cover the feature.

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Existing tests cover the feature.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Existing tests cover the feature.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Existing tests cover the feature.

  • fast/canvas/canvas-path-object-expected.txt:
  • inspector/profiler/canvas2d/canvas2d-api-changes.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
Location:
trunk
Files:
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r143345 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        Existing tests cover the feature.
     11
     12        * Source/cmake/WebKitFeatures.cmake:
     13
    1142013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
    215

  • trunk/LayoutTests/ChangeLog

    r143500 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        Existing tests cover the feature.
     11
     12        * fast/canvas/canvas-path-object-expected.txt:
     13        * inspector/profiler/canvas2d/canvas2d-api-changes.html:
     14        * platform/chromium/TestExpectations:
     15        * platform/efl/TestExpectations:
     16        * platform/gtk/TestExpectations:
     17        * platform/mac/TestExpectations:
     18
    1192013-02-20  Ian Vollick <vollick@chromium.org>
    220

  • trunk/LayoutTests/fast/canvas/canvas-path-object-expected.txt

    r140604 r143505  
    1 CONSOLE MESSAGE: line 5: ReferenceError: Can't find variable: Path
    21Ensure that the constructor for Path object and dependent functions exist.
    32
    … …  
    65
    76PASS typeof document.getElementById is "function"
    8 FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
     7PASS path is an instance of Path
     8PASS typeof path.closePath is "function"
     9PASS typeof path.moveTo is "function"
     10PASS typeof path.lineTo is "function"
     11PASS typeof path.quadraticCurveTo is "function"
     12PASS typeof path.bezierCurveTo is "function"
     13PASS typeof path.arcTo is "function"
     14PASS typeof path.arc is "function"
     15PASS typeof path.rect is "function"
     16PASS successfullyParsed is true
    917
    1018TEST COMPLETE

  • trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html

    r141141 r143505  
    1111 */
    1212CanvasRenderingContext2DResource.AttributeProperties = [
     13    "currentPath",
    1314    "strokeStyle",
    1415    "fillStyle",

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r143502 r143505  
    43224322webkit.org/b/109158 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ ImageOnlyFailure Pass ]
    43234323
    4324 # Rebaseline after currentPath
    4325 webkit.org/b/108246 fast/canvas/canvas-currentPath.html [ Failure ]
    4326 webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath.html [ Failure ]
    4327 webkit.org/b/108246 fast/canvas/canvas-currentPath-crash.html [ Failure ]
    4328 webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath-crash.html [ Failure ]
    4329 
    43304324# Broken by Skia flag changes in r139445
    43314325crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]
    … …  
    43494343webkit.org/b/106858 [ Linux Win Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure Pass ]
    43504344
    4351 
    4352 # Needs rebaseline after enabling CANVAS_PATH.
    4353 webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
    4354 webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-constructors.html [ Failure ]
    4355 webkit.org/b/108508 fast/canvas/canvas-path-object.html [ Failure ]
    4356 webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-object.html [ Failure ]
    4357 webkit.org/b/108508 inspector/profiler/canvas2d/canvas2d-api-changes.html [ Failure ]
    4358 
    43594345# This is won't fix, as the debug and release versions differ.
    43604346

  • trunk/LayoutTests/platform/efl/TestExpectations

    r143458 r143505  
    17981798inspector/editor/text-editor-smart-braces.html
    17991799
    1800 # Remove from list after enabling CANVAS_PATH
    1801 webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
    1802 webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
    1803 
    18041800# Test fails on JSC platforms due to GC timing problems
    18051801webkit.org/b/106957 svg/dom/SVGViewSpec-invalid-ref-crash.html [ Failure ]

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r143463 r143505  
    13831383webkit.org/b/103740 editing/selection/caret-alignment-for-vertical-text.html [ Failure ]
    13841384
    1385 # Remove from list after enabling CANVAS_PATH
    1386 webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
    1387 webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
    1388 
    13891385webkit.org/b/104054 svg/custom/use-href-update-crash.svg [ Failure ]
    13901386

  • trunk/LayoutTests/platform/mac/TestExpectations

    r143419 r143505  
    144144http/tests/security/cross-origin-worker-indexeddb.html
    145145http/tests/security/no-indexeddb-from-sandbox.html
    146 
    147 # Remove from list after enabling CANVAS_PATH
    148 fast/canvas/canvas-currentPath.html
    149 fast/canvas/canvas-path-constructors.html
    150 fast/canvas/canvas-currentPath-crash.html
    151146
    152147# This port doesn't support DeviceMotion or DeviceOrientation.

  • trunk/Source/JavaScriptCore/ChangeLog

    r143430 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        Existing tests cover the feature.
     11
     12        * Configurations/FeatureDefines.xcconfig:
     13
    1142013-02-19  Mark Rowe  <mrowe@apple.com>
    215

  • trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r142701 r143505  
    3535ENABLE_ACCELERATED_2D_CANVAS = ;
    3636ENABLE_BLOB = ENABLE_BLOB;
    37 ENABLE_CANVAS_PATH = ;
     37ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
    3838ENABLE_CANVAS_PROXY = ;
    3939ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;

  • trunk/Source/WTF/wtf/FeatureDefines.h

    r143248 r143505  
    326326
    327327#if !defined(ENABLE_CANVAS_PATH)
    328 #define ENABLE_CANVAS_PATH 0
     328#define ENABLE_CANVAS_PATH 1
    329329#endif
    330330

  • trunk/Source/WebCore/ChangeLog

    r143503 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        Existing tests cover the feature.
     11
     12        * Configurations/FeatureDefines.xcconfig:
     13
    1142013-02-20  Sheriff Bot  <webkit.review.bot@gmail.com>
    215

  • trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r142701 r143505  
    3535ENABLE_ACCELERATED_2D_CANVAS = ;
    3636ENABLE_BLOB = ENABLE_BLOB;
    37 ENABLE_CANVAS_PATH = ;
     37ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
    3838ENABLE_CANVAS_PROXY = ;
    3939ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;

  • trunk/Source/WebKit/chromium/ChangeLog

    r143502 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        * features.gypi:
     11
    1122013-02-15  Dirk Schulze  <krit@webkit.org>
    213

  • trunk/Source/WebKit/chromium/features.gypi

    r143211 r143505  
    3737      'ENABLE_BLOB=1',
    3838      'ENABLE_BLOB_SLICE=1',
    39       'ENABLE_CANVAS_PATH=0',
     39      'ENABLE_CANVAS_PATH=1',
    4040      'ENABLE_CANVAS_PROXY=1',
    4141      'ENABLE_CHANNEL_MESSAGING=1',

  • trunk/Source/WebKit/mac/ChangeLog

    r143428 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        * Configurations/FeatureDefines.xcconfig:
     11
    1122013-02-19  Tim Horton  <timothy_horton@apple.com>
    213

  • trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig

    r142701 r143505  
    3535ENABLE_ACCELERATED_2D_CANVAS = ;
    3636ENABLE_BLOB = ENABLE_BLOB;
    37 ENABLE_CANVAS_PATH = ;
     37ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
    3838ENABLE_CANVAS_PROXY = ;
    3939ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;

  • trunk/Source/WebKit2/ChangeLog

    r143499 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        * Configurations/FeatureDefines.xcconfig:
     11
    1122013-02-20  Laszlo Gombos  <l.gombos@samsung.com>
    213

  • trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig

    r142701 r143505  
    3535ENABLE_ACCELERATED_2D_CANVAS = ;
    3636ENABLE_BLOB = ENABLE_BLOB;
    37 ENABLE_CANVAS_PATH = ;
     37ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
    3838ENABLE_CANVAS_PROXY = ;
    3939ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;

  • trunk/Source/cmake/WebKitFeatures.cmake

    r142664 r143505  
    1919    WEBKIT_OPTION_DEFINE(ENABLE_BATTERY_STATUS "Toggle battery status API support" OFF)
    2020    WEBKIT_OPTION_DEFINE(ENABLE_BLOB "Toggle Blob support" OFF)
    21     WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PATH "Toggle Canvas Path support" OFF)
     21    WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PATH "Toggle Canvas Path support" ON)
    2222    WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PROXY "Toggle CanvasProxy support" OFF)
    2323    WEBKIT_OPTION_DEFINE(ENABLE_CHANNEL_MESSAGING "Toggle MessageChannel and MessagePort support" ON)

  • trunk/Tools/ChangeLog

    r143504 r143505  
     12013-02-20  Dirk Schulze  <krit@webkit.org>
     2
     3        Enable CANVAS_PATH flag
     4        https://bugs.webkit.org/show_bug.cgi?id=108508
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable CANVAS_PATH flag on trunk.
     9
     10        * Scripts/webkitperl/FeatureList.pm:
     11
    1122013-02-20  Tony Chang  <tony@chromium.org>
    213

  • trunk/Tools/Scripts/webkitperl/FeatureList.pm

    r142617 r143505  
    166166
    167167    { option => "canvas-path", desc => "Toggle Canvas Path support",
    168       define => "ENABLE_CANVAS_PATH", default => 0, value => \$canvasPathSupport },
     168      define => "ENABLE_CANVAS_PATH", default => 1, value => \$canvasPathSupport },
    169169
    170170    { option => "canvas-proxy", desc => "Toggle CanvasProxy support",
Note: See TracChangeset for help on using the changeset viewer.