Changeset 143538 in webkit

Timestamp:

Feb 20, 2013, 4:49:57 PM (12 years ago)

Author:

alecflett@chromium.org

Message:

LevelDB: Remove excess vector copy
​https://bugs.webkit.org/show_bug.cgi?id=110399

Reviewed by Tony Chang.

Remove an extra copy introduced by the makeVector function.

No new tests, this is covered by existing tests.

• platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::safeGet):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/leveldb/LevelDBDatabase.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-20  Alec Flett  <alecflett@chromium.org>
+
+        LevelDB: Remove excess vector copy
+        https://bugs.webkit.org/show_bug.cgi?id=110399
+
+        Reviewed by Tony Chang.
+
+        Remove an extra copy introduced by the makeVector function.
+
+        No new tests, this is covered by existing tests.
+
+        * platform/leveldb/LevelDBDatabase.cpp:
+        (WebCore::LevelDBDatabase::safeGet):
+
 2013-02-20  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

@@ -76 +76 @@
 }
 
-static Vector<char> makeVector(const std::string& s)
-{
-    Vector<char> res;
-    res.append(s.c_str(), s.length());
-    return res;
-}
-
 class ComparatorAdapter : public leveldb::Comparator {
 public:
@@ -228 +221 @@
     if (s.ok()) {
         found = true;
-        value = makeVector(result);
+        value.clear();
+        value.append(result.c_str(), result.length());
         return true;
     }