Changeset 143784 in webkit

Timestamp:

Feb 22, 2013, 1:30:51 PM (12 years ago)

Author:

reed@google.com

Message:

Check for null-device when calling createCompatibleDevice
​https://bugs.webkit.org/show_bug.cgi?id=107981

Reviewed by James Robinson.

No new tests. Current tests provided coverage. Site in the wild triggered the failure
(cairo failed to allocate a huge surface).

• platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/ImageBufferSkia.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-22  Mike Reed  <reed@google.com>
+
+        Check for null-device when calling createCompatibleDevice
+        https://bugs.webkit.org/show_bug.cgi?id=107981
+
+        Reviewed by James Robinson.
+
+        No new tests. Current tests provided coverage. Site in the wild triggered the failure
+        (cairo failed to allocate a huge surface).
+
+        * platform/graphics/skia/ImageBufferSkia.cpp:
+        (WebCore::ImageBuffer::ImageBuffer):
+
 2013-02-22  Chris Rogers  <crogers@google.com>
 

trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

@@ -130 +130 @@
 
     SkAutoTUnref<SkDevice> device(compatibleContext->platformContext()->createCompatibleDevice(size, hasAlpha));
+    if (!device.get()) {
+        success = false;
+        return;
+    }
+
     SkPixelRef* pixelRef = device->accessBitmap(false).pixelRef();
     if (!pixelRef) {