Changeset 144020 in webkit

Timestamp:

Feb 26, 2013, 12:49:28 AM (14 years ago)

Author:

oliver@apple.com

Message:

Appease static analyzer warning about null string passed to strlen
​https://bugs.webkit.org/show_bug.cgi?id=110658

Reviewed by Benjamin Poulain.

Add a null check before calling strlen

• wtf/Threading.cpp:

(WTF::createThread):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Threading.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-02-26  Oliver Hunt  <oliver@apple.com>
+
+        Appease static analyzer warning about null string passed to strlen
+        https://bugs.webkit.org/show_bug.cgi?id=110658
+
+        Reviewed by Benjamin Poulain.
+
+        Add a null check before calling strlen
+
+        * wtf/Threading.cpp:
+        (WTF::createThread):
+
 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WTF/wtf/Threading.cpp

@@ -75 +75 @@
     // be truncated silently, but we'd like callers to know about the limit.
 #if !LOG_DISABLED
-    if (strlen(name) > 31)
+    if (name && strlen(name) > 31)
         LOG_ERROR("Thread name \"%s\" is longer than 31 characters and will be truncated by Visual Studio", name);
 #endif