Changeset 144036 in webkit

Timestamp:

Feb 26, 2013, 3:41:23 AM (14 years ago)

Author:

mkwst@chromium.org

Message:

XSSAuditor: Don't rely on implicit casting when copying the document's KURL to String.
​https://bugs.webkit.org/show_bug.cgi?id=110859

Reviewed by Jochen Eisinger.

XSSAuditor::init should explicitly make a thread-safe copy of the
document's URL as a String rather than relying on implicit casting from
a copy of the KURL.

This shouldn't change any visible behavior; all existing XSSAuditor
tests should continue to pass. They'll now just be a bit more smug while
doing so.

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/XSSAuditor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-26  Mike West  <mkwst@chromium.org>
+
+        XSSAuditor: Don't rely on implicit casting when copying the document's KURL to String.
+        https://bugs.webkit.org/show_bug.cgi?id=110859
+
+        Reviewed by Jochen Eisinger.
+
+        XSSAuditor::init should explicitly make a thread-safe copy of the
+        document's URL as a String rather than relying on implicit casting from
+        a copy of the KURL.
+
+        This shouldn't change any visible behavior; all existing XSSAuditor
+        tests should continue to pass. They'll now just be a bit more smug while
+        doing so.
+
+        * html/parser/XSSAuditor.cpp:
+        (WebCore::XSSAuditor::init):
+
 2013-02-26  Takashi Sakamoto  <tasak@google.com>
 

trunk/Source/WebCore/html/parser/XSSAuditor.cpp

@@ -286 +286 @@
     if (!m_reportURL.isEmpty()) {
         // May need these for reporting later on.
-        m_originalURL = m_documentURL.copy();
+        m_originalURL = m_documentURL.string().isolatedCopy();
         m_originalHTTPBody = httpBodyAsString;
     }