Changeset 144068 in webkit

Timestamp:

Feb 26, 2013, 9:50:46 AM (14 years ago)

Author:

Antti Koivisto

Message:

REGRESSION(r143986): fast/files/revoke-blob-url.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=110885

Reviewed by Alexey Proskuryakov.

The ResourceRequest string constructor assumes that the string is a valid URL. Use KURL constructor instead.

• html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/DOMURL.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-26  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION(r143986): fast/files/revoke-blob-url.html asserts
+        https://bugs.webkit.org/show_bug.cgi?id=110885
+        
+        Reviewed by Alexey Proskuryakov.
+
+        The ResourceRequest string constructor assumes that the string is a valid URL. Use KURL constructor instead.
+
+        * html/DOMURL.cpp:
+        (WebCore::DOMURL::revokeObjectURL):
+
 2013-02-26  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/html/DOMURL.cpp

@@ -115 +115 @@
         return;
 
-    ResourceRequest request(urlString);
+    KURL url(KURL(), urlString);
+    ResourceRequest request(url);
 #if ENABLE(CACHE_PARTITIONING)
     request.setCachePartition(scriptExecutionContext->topOrigin()->cachePartition());
@@ -121 +122 @@
     MemoryCache::removeRequestFromCache(scriptExecutionContext, request);
 
-    KURL url(KURL(), urlString);
     HashSet<String>& blobURLs = scriptExecutionContext->publicURLManager().blobURLs();
     if (blobURLs.contains(url.string())) {