Changeset 144070 in webkit

Timestamp:

Feb 26, 2013, 10:29:27 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=110869

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-26
Reviewed by Martin Robinson.

Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels.

• UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuDefaultMenu): Modified test in order to give more space
to the media controls.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/tests/TestContextMenu.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
+        https://bugs.webkit.org/show_bug.cgi?id=110869
+
+        Reviewed by Martin Robinson.
+
+        Test was failing because of new media controls needs more space to be
+        painted than just 10x10 pixels.
+
+        * UIProcess/API/gtk/tests/TestContextMenu.cpp:
+        (testContextMenuDefaultMenu): Modified test in order to give more space
+        to the media controls.
+
 2013-02-26  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp

@@ -355 +355 @@
         " <img style='position:absolute; left:1; top:10' src='0xdeadbeef' width=5 height=5></img>"
         " <a style='position:absolute; left:1; top:20' href='http://www.webkitgtk.org/logo' title='WebKitGTK+ Logo'><img src='0xdeadbeef' width=5 height=5></img></a>"
-        " <video style='position:absolute; left:1; top:30' width=10 height=10 controls='controls'><source src='movie.ogg' type='video/ogg' /></video>"
-        " <input style='position:absolute; left:1; top:50' size='10'></input>"
+        " <input style='position:absolute; left:1; top:30' size='10'></input>"
+        " <video style='position:absolute; left:1; top:50' width='300' height='300' controls='controls'><source src='movie.ogg' type='video/ogg' /></video>"
         "</body></html>";
     test->loadHtml(linksHTML, "file:///");
@@ -383 +383 @@
     // Context menu for image video.
     test->m_expectedMenuType = ContextMenuDefaultTest::Video;
-    test->showContextMenuAtPositionAndWaitUntilFinished(1, 30);
+    test->showContextMenuAtPositionAndWaitUntilFinished(1, 50);
 
     // Context menu for editable.
     test->m_expectedMenuType = ContextMenuDefaultTest::Editable;
-    test->showContextMenuAtPositionAndWaitUntilFinished(5, 55);
+    test->showContextMenuAtPositionAndWaitUntilFinished(5, 35);
 }