Changeset 144977 in webkit

Timestamp:

Mar 6, 2013, 2:12:27 PM (12 years ago)

Author:

nghanavatian@rim.com

Message:

[BlackBerry] Selection handles don't drag to expand correctly for RTL languages
​https://bugs.webkit.org/show_bug.cgi?id=111618

Reviewed by Rob Buis.

PR 303712
If we are using a RTL language, we should ensure that the selection handles are angled the right way.
Further, when expanding the selection, the start and end handles should be appropriately set so that
expansion in the natural direction is possible.

Internally reviewed by Mike Fenton.

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

• WebKitSupport/SelectionHandler.h:

(SelectionHandler):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/SelectionHandler.cpp (modified) (2 diffs)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-03-06  Nima Ghanavatian  <nghanavatian@rim.com>
+
+        [BlackBerry] Selection handles don't drag to expand correctly for RTL languages
+        https://bugs.webkit.org/show_bug.cgi?id=111618
+
+        Reviewed by Rob Buis.
+
+        PR 303712
+        If we are using a RTL language, we should ensure that the selection handles are angled the right way.
+        Further, when expanding the selection, the start and end handles should be appropriately set so that
+        expansion in the natural direction is possible.
+
+        Internally reviewed by Mike Fenton.
+
+        * WebKitSupport/SelectionHandler.cpp:
+        (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
+        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
+        * WebKitSupport/SelectionHandler.h:
+        (SelectionHandler):
+
 2013-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp

@@ -1206 +1206 @@
     }
 
-    if (!frame->selection()->selection().isBaseFirst() || isRTL ) {
+    if (!frame->selection()->selection().isBaseFirst()) {
         // End handle comes before start, invert the caret reference points.
         WebCore::IntRect tmpCaret(startCaret);
@@ -1221 +1221 @@
         m_webPage->m_selectionOverlay->draw(visibleSelectionRegion);
 
-
     VisibleSelection currentSelection = frame->selection()->selection();
     SelectionDetails details(startCaret, endCaret, visibleSelectionRegion, inputNodeOverridesTouch(),
-        m_lastSelection != currentSelection, requestedSelectionHandlePosition(frame->selection()->selection()));
+        m_lastSelection != currentSelection, requestedSelectionHandlePosition(frame->selection()->selection()), isRTL);
 
     m_webPage->m_client->notifySelectionDetailsChanged(details);