Changeset 145013 in webkit

Timestamp:

Mar 6, 2013, 5:24:42 PM (12 years ago)

Author:

inferno@chromium.org

Message:

Crash in SVGViewSpec::viewTarget
​https://bugs.webkit.org/show_bug.cgi?id=111648

Reviewed by Philip Rogers.

• svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewTarget):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGViewSpec.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-06  Abhishek Arya  <inferno@chromium.org>
+
+        Crash in SVGViewSpec::viewTarget
+        https://bugs.webkit.org/show_bug.cgi?id=111648
+
+        Reviewed by Philip Rogers.
+
+        * svg/SVGViewSpec.cpp:
+        (WebCore::SVGViewSpec::viewTarget):
+
 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebCore/svg/SVGViewSpec.cpp

@@ -143 +143 @@
     if (!m_contextElement)
         return 0;
-    return static_cast<SVGElement*>(m_contextElement->treeScope()->getElementById(m_viewTargetString));
+    Element* element = m_contextElement->treeScope()->getElementById(m_viewTargetString);
+    if (!element || !element->isSVGElement())
+        return 0;
+    return static_cast<SVGElement*>(element);
 }