Changeset 145352 in webkit

Timestamp:

Mar 11, 2013, 3:36:21 AM (14 years ago)

Author:

hayato@chromium.org

Message:

Make sure that CSSSelector::setValue() is never called after parsing its pseudoType.
​https://bugs.webkit.org/show_bug.cgi?id=111957

Reviewed by Hajime Morrita.

It'd be nice to have an assertion here since
CSSSelector::pseudoType() will never parse a new value after it
parses a value and m_pseudoType is set to non-PseudoNotParsed.

No new tests (no change in behaviour).

• css/CSSSelector.h:

(WebCore::CSSSelector::setValue):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSSelector.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-11  Hayato Ito  <hayato@chromium.org>
+
+        Make sure that CSSSelector::setValue() is never called after parsing its pseudoType.
+        https://bugs.webkit.org/show_bug.cgi?id=111957
+
+        Reviewed by Hajime Morrita.
+
+        It'd be nice to have an assertion here since
+        CSSSelector::pseudoType() will never parse a new value after it
+        parses a value and m_pseudoType is set to non-PseudoNotParsed.
+
+        No new tests (no change in behaviour).
+
+        * css/CSSSelector.h:
+        (WebCore::CSSSelector::setValue):
+
 2013-03-11  Takashi Sakamoto  <tasak@google.com>
 

trunk/Source/WebCore/css/CSSSelector.h

@@ -358 +358 @@
 {
     ASSERT(m_match != Tag);
+    ASSERT(m_pseudoType == PseudoNotParsed);
     // Need to do ref counting manually for the union.
     if (m_hasRareData) {