Changeset 145380 in webkit

Timestamp:

Mar 11, 2013, 12:24:46 PM (14 years ago)

Author:

beidson@apple.com

Message:

CoreIPC crash in NetworkProcess after WebProcess crash.
<rdar://problem/13124146> and ​https://bugs.webkit.org/show_bug.cgi?id=112046

Reviewed by Alexey Proskuryakov.

• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::connectionToWebProcessDidClose): Don't null out the connection backpointer on crash.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/SchedulableLoader.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-03-11  Brady Eidson  <beidson@apple.com>
+
+        CoreIPC crash in NetworkProcess after WebProcess crash.
+        <rdar://problem/13124146> and https://bugs.webkit.org/show_bug.cgi?id=112046
+
+        Reviewed by Alexey Proskuryakov.
+
+        * NetworkProcess/SchedulableLoader.cpp:
+        (WebKit::SchedulableLoader::connectionToWebProcessDidClose): Don't null out the connection backpointer on crash.
+
 2013-03-11  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit2/NetworkProcess/SchedulableLoader.cpp

@@ -82 +82 @@
 void SchedulableLoader::connectionToWebProcessDidClose()
 {
-    m_connection = 0;
-
-    // FIXME (NetworkProcess): Cancel the load. The request may be long-living, so we don't want it to linger around after all clients are gone.
+    // FIXME (NetworkProcess): <rdar://problem/12890500>: Cancel the load. The request may be long-living, so we don't want it to linger around after all clients are gone.
 }