Changeset 145389 in webkit

Timestamp:

Mar 11, 2013, 12:57:23 PM (14 years ago)

Author:

timothy_horton@apple.com

Message:

TiledBacking scrolling coverage can be unfairly limited for clients who do scrolling outside the web view
​https://bugs.webkit.org/show_bug.cgi?id=111958
<rdar://problem/13356896>

Reviewed by Darin Adler.

Don't limit TiledBacking coverage if the client has opted into using
its exposed rect to allow scrolling above the web view.

• platform/graphics/TiledBacking.h:
• platform/graphics/ca/mac/TileController.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/TiledBacking.h (modified) (1 diff)
• platform/graphics/ca/mac/TileController.h (modified) (1 diff)
• rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-11  Tim Horton  <timothy_horton@apple.com>
+
+        TiledBacking scrolling coverage can be unfairly limited for clients who do scrolling outside the web view
+        https://bugs.webkit.org/show_bug.cgi?id=111958
+        <rdar://problem/13356896>
+
+        Reviewed by Darin Adler.
+
+        Don't limit TiledBacking coverage if the client has opted into using
+        its exposed rect to allow scrolling above the web view.
+
+        * platform/graphics/TiledBacking.h:
+        * platform/graphics/ca/mac/TileController.h:
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::adjustTiledBackingCoverage):
+
 2013-03-11  Rajeev Sarvaria  <rsarvaria@blackberry.com>
 

trunk/Source/WebCore/platform/graphics/TiledBacking.h

@@ -50 +50 @@
     virtual void setExposedRect(const FloatRect&) = 0;
     virtual void setClipsToExposedRect(bool) = 0;
+    virtual bool clipsToExposedRect() = 0;
 
     virtual void prepopulateRect(const FloatRect&) = 0;

trunk/Source/WebCore/platform/graphics/ca/mac/TileController.h

@@ -109 +109 @@
     virtual void setVisibleRect(const FloatRect&) OVERRIDE;
     virtual void setExposedRect(const FloatRect&) OVERRIDE;
+    virtual bool clipsToExposedRect() OVERRIDE { return m_clipsToExposedRect; }
     virtual void setClipsToExposedRect(bool) OVERRIDE;
     virtual void prepopulateRect(const FloatRect&) OVERRIDE;

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -206 +206 @@
     if (frame) {
         FrameView* frameView = frame->view();
-        if (frameView->horizontalScrollbarMode() != ScrollbarAlwaysOff)
+        bool clipsToExposedRect = tiledBacking()->clipsToExposedRect();
+        if (frameView->horizontalScrollbarMode() != ScrollbarAlwaysOff || clipsToExposedRect)
             tileCoverage |= TiledBacking::CoverageForHorizontalScrolling;
 
-        if (frameView->verticalScrollbarMode() != ScrollbarAlwaysOff)
+        if (frameView->verticalScrollbarMode() != ScrollbarAlwaysOff || clipsToExposedRect)
             tileCoverage |= TiledBacking::CoverageForVerticalScrolling;