Changeset 145412 in webkit

Timestamp:

Mar 11, 2013 3:15:06 PM (11 years ago)

Author:

ggaren@apple.com

Message:

Some StringHasher tests are broken because of missing null termination
​https://bugs.webkit.org/show_bug.cgi?id=111284

Reviewed by Darin Adler.

• TestWebKitAPI/Tests/WTF/StringHasher.cpp:

(TestWebKitAPI): Added null termination since C strings are null-terminated.
(TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
the bug caught by it is now fixed.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WTF/StringHasher.cpp (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-03-08  Geoffrey Garen  <ggaren@apple.com>
+
+        Some StringHasher tests are broken because of missing null termination
+        https://bugs.webkit.org/show_bug.cgi?id=111284
+
+        Reviewed by Darin Adler.
+
+        * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
+        (TestWebKitAPI): Added null termination since C strings are null-terminated.
+        (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
+        the bug caught by it is now fixed.
+
 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp

@@ -38 +38 @@
 static const LChar testALChars[6] = { 0x41, 0x95, 0xFF, 0x50, 0x01, 0 };
 static const UChar testAUChars[6] = { 0x41, 0x95, 0xFF, 0x50, 0x01, 0 };
-static const UChar testBUChars[5] = { 0x41, 0x95, 0xFFFF, 0x1080, 0x01 };
+static const UChar testBUChars[6] = { 0x41, 0x95, 0xFFFF, 0x1080, 0x01, 0 };
 
 static const unsigned testAHash1 = 0xEA32B004;
@@ -108 +108 @@
 }
 
-#if OS(ANDROID)
-// Failing on Android. http://webkit.org/b/111284
-# define MAYBE_StringHasher_addCharacters DISABLED_StringHasher_addCharacters
-#else
-# define MAYBE_StringHasher_addCharacters StringHasher_addCharacters
-#endif
-
-TEST(WTF, MAYBE_StringHasher_addCharacters)
+TEST(WTF, StringHasher_addCharacters)
 {
     StringHasher hasher;
@@ -274 +267 @@
 }
 
-#if OS(ANDROID)
-// Failing on Android. http://webkit.org/b/111284
-# define MAYBE_StringHasher_addCharactersAssumingAligned DISABLED_StringHasher_addCharactersAssumingAligned
-#else
-# define MAYBE_StringHasher_addCharactersAssumingAligned StringHasher_addCharactersAssumingAligned
-#endif
-
-TEST(WTF, MAYBE_StringHasher_addCharactersAssumingAligned)
+TEST(WTF, StringHasher_addCharactersAssumingAligned)
 {
     StringHasher hasher;