⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 145444 in webkit


Ignore:
Timestamp:
Mar 11, 2013, 5:50:46 PM (14 years ago)
Author:
inferno@chromium.org
Message:

Replace static_cast with to* helper functions.
​https://bugs.webkit.org/show_bug.cgi?id=112045

Reviewed by Eric Seidel.

Source/WebCore:

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::removeMethodCustom):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):

  • bindings/v8/custom/V8NamedNodesCollection.cpp:

(WebCore::V8NamedNodesCollection::namedItem):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::wrap):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::pushAnchorElementDown):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::splitTreeToNode):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameContentsCompositor):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::idChanged):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::fromFrameOwnerElement):

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::getPlugin):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::create):

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
(WebKit::WebPageSerializerImpl::endTagToString):
(WebKit::WebPageSerializerImpl::buildContentForNode):
(WebKit::WebPageSerializerImpl::collectTargetFrames):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::autocompleteHandleKeyEvent):
(WebKit::WebViewImpl::enterFullScreenForElement):

Source/WebKit/mac:

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]):

Location:
trunk/Source
Files:
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r145442 r145444  
     12013-03-11  Abhishek Arya  <inferno@chromium.org>
     2
     3        Replace static_cast with to* helper functions.
     4        https://bugs.webkit.org/show_bug.cgi?id=112045
     5
     6        Reviewed by Eric Seidel.
     7
     8        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
     9        (WebCore::V8HTMLOptionsCollection::removeMethodCustom):
     10        (WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
     11        * bindings/v8/custom/V8NamedNodesCollection.cpp:
     12        (WebCore::V8NamedNodesCollection::namedItem):
     13        * bindings/v8/custom/V8NodeCustom.cpp:
     14        (WebCore::wrap):
     15        * editing/BreakBlockquoteCommand.cpp:
     16        (WebCore::BreakBlockquoteCommand::doApply):
     17        * editing/CompositeEditCommand.cpp:
     18        (WebCore::CompositeEditCommand::insertNodeAt):
     19        (WebCore::CompositeEditCommand::pushAnchorElementDown):
     20        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
     21        (WebCore::CompositeEditCommand::splitTreeToNode):
     22        * editing/InsertParagraphSeparatorCommand.cpp:
     23        (WebCore::InsertParagraphSeparatorCommand::doApply):
     24        * loader/archive/cf/LegacyWebArchive.cpp:
     25        (WebCore::LegacyWebArchive::create):
     26        * platform/chromium/PasteboardChromium.cpp:
     27        (WebCore::Pasteboard::writeImage):
     28        * platform/mac/HTMLConverter.mm:
     29        (+[WebHTMLConverter editingAttributedStringFromRange:]):
     30        * rendering/RenderLayerBacking.cpp:
     31        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
     32        * rendering/RenderLayerCompositor.cpp:
     33        (WebCore::RenderLayerCompositor::frameContentsCompositor):
     34        (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
     35        * rendering/RenderSnapshottedPlugIn.cpp:
     36        (WebCore::RenderSnapshottedPlugIn::plugInImageElement):
     37        * rendering/mathml/RenderMathMLOperator.cpp:
     38        (WebCore::RenderMathMLOperator::updateFromElement):
     39        * rendering/svg/RenderSVGResourceContainer.cpp:
     40        (WebCore::RenderSVGResourceContainer::idChanged):
     41
    1422013-03-11  James Robinson  <jamesr@chromium.org>
    243

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

    r143850 r145444  
    8686{
    8787    HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(args.Holder());
    88     HTMLSelectElement* base = static_cast<HTMLSelectElement*>(imp->ownerNode());
     88    HTMLSelectElement* base = toHTMLSelectElement(imp->ownerNode());
    8989    return removeElement(base, args);
    9090}
    … …  
    149149{
    150150    HTMLOptionsCollection* collection = V8HTMLOptionsCollection::toNative(info.Holder());
    151     HTMLSelectElement* base = static_cast<HTMLSelectElement*>(collection->ownerNode());
     151    HTMLSelectElement* base = toHTMLSelectElement(collection->ownerNode());
    152152    return toOptionsCollectionSetter(index, value, base, info.GetIsolate());
    153153}

  • trunk/Source/WebCore/bindings/v8/custom/V8NamedNodesCollection.cpp

    r135667 r145444  
    4747    for (unsigned i = 0; i < m_nodes.size(); ++i) {
    4848        Node* node = m_nodes[i].get();
    49         if (node->hasID() && static_cast<Element*>(node)->getIdAttribute() == id)
     49        if (node->hasID() && toElement(node)->getIdAttribute() == id)
    5050            return node;
    5151    }

  • trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp

    r144891 r145444  
    134134            return wrap(static_cast<SVGElement*>(impl), creationContext, isolate);
    135135#endif
    136         return V8Element::createWrapper(static_cast<Element*>(impl), creationContext, isolate);
     136        return V8Element::createWrapper(toElement(impl), creationContext, isolate);
    137137    case Node::ATTRIBUTE_NODE:
    138138        return wrap(static_cast<Attr*>(impl), creationContext, isolate);

  • trunk/Source/WebCore/editing/BreakBlockquoteCommand.cpp

    r137221 r145444  
    133133   
    134134    // Insert a clone of the top blockquote after the break.
    135     RefPtr<Element> clonedBlockquote = static_cast<Element*>(topBlockquote)->cloneElementWithoutChildren();
     135    RefPtr<Element> clonedBlockquote = toElement(topBlockquote)->cloneElementWithoutChildren();
    136136    insertNodeAfter(clonedBlockquote.get(), breakNode.get());
    137137   
    … …  
    151151                listChildNode = listChildNode->nextSibling();
    152152            if (listChildNode && listChildNode->renderer() && listChildNode->renderer()->isListItem())
    153                 setNodeAttribute(static_cast<Element*>(clonedChild.get()), startAttr, String::number(toRenderListItem(listChildNode->renderer())->value()));
     153                setNodeAttribute(clonedChild, startAttr, String::number(toRenderListItem(listChildNode->renderer())->value()));
    154154        }
    155155           

  • trunk/Source/WebCore/editing/CompositeEditCommand.cpp

    r144911 r145444  
    365365            insertNodeBefore(insertChild, child);
    366366        else
    367             appendNode(insertChild, static_cast<Element*>(refChild));
     367            appendNode(insertChild, toElement(refChild));
    368368    } else if (caretMinOffset(refChild) >= offset)
    369369        insertNodeBefore(insertChild, refChild);
    … …  
    980980   
    981981    setEndingSelection(VisibleSelection::selectionFromContentsOfNode(anchorNode));
    982     applyStyledElement(static_cast<Element*>(anchorNode));
     982    applyStyledElement(toElement(anchorNode));
    983983    // Clones of anchorNode have been pushed down, now remove it.
    984984    if (anchorNode->inDocument())
    … …  
    12941294                // If listNode does NOT appear at the end, then we should consider it as a regular paragraph.
    12951295                // e.g. <ul><li> <ul><li><br></li></ul> hello</li></ul> should become <ul><li> <div><br></div> hello</li></ul> at the end
    1296                 splitElement(static_cast<Element*>(blockEnclosingList), listNode);
     1296                splitElement(toElement(blockEnclosingList), listNode);
    12971297                removeNodePreservingChildren(listNode->parentNode());
    12981298                newBlock = createListItemElement(document());
    … …  
    13101310        // If emptyListItem follows another list item or nested list, split the list node.
    13111311        if (isListItem(previousListNode.get()) || isListElement(previousListNode.get()))
    1312             splitElement(static_cast<Element*>(listNode.get()), emptyListItem);
     1312            splitElement(toElement(listNode.get()), emptyListItem);
    13131313
    13141314        // If emptyListItem is followed by other list item or nested list, then insert newBlock before the list node.
    … …  
    14691469        VisiblePosition positionInNode = firstPositionInOrBeforeNode(node.get());
    14701470        if (positionInParent != positionInNode)
    1471             splitElement(static_cast<Element*>(node->parentNode()), node);
     1471            splitElement(toElement(node->parentNode()), node);
    14721472    }
    14731473

  • trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp

    r144911 r145444  
    228228            if (m_pasteBlockqutoeIntoUnquotedArea) {
    229229                if (Node* highestBlockquote = highestEnclosingNodeOfType(canonicalPos, &isMailBlockquote))
    230                     startBlock = static_cast<Element*>(highestBlockquote);
     230                    startBlock = toElement(highestBlockquote);
    231231            }
    232232

  • trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp

    r144565 r145444  
    525525        Frame* childFrame;
    526526        if ((node->hasTagName(HTMLNames::frameTag) || node->hasTagName(HTMLNames::iframeTag) || node->hasTagName(HTMLNames::objectTag)) &&
    527              (childFrame = static_cast<HTMLFrameOwnerElement*>(node)->contentFrame())) {
     527            (childFrame = toFrameOwnerElement(node)->contentFrame())) {
    528528            if (frameFilter && !frameFilter->shouldIncludeSubframe(childFrame))
    529529                continue;

  • trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp

    r144568 r145444  
    147147    AtomicString urlString;
    148148    if (node->hasTagName(HTMLNames::imgTag) || node->hasTagName(HTMLNames::inputTag))
    149         urlString = static_cast<Element*>(node)->getAttribute(HTMLNames::srcAttr);
     149        urlString = toElement(node)->getAttribute(HTMLNames::srcAttr);
    150150#if ENABLE(SVG)
    151151    else if (node->hasTagName(SVGNames::imageTag))
    152         urlString = static_cast<Element*>(node)->getAttribute(XLinkNames::hrefAttr);
     152        urlString = toElement(node)->getAttribute(XLinkNames::hrefAttr);
    153153#endif
    154154    else if (node->hasTagName(HTMLNames::embedTag) || node->hasTagName(HTMLNames::objectTag)) {
    155         Element* element = static_cast<Element*>(node);
     155        Element* element = toElement(node);
    156156        urlString = element->getAttribute(element->imageSourceAttributeName());
    157157    }

  • trunk/Source/WebCore/platform/mac/HTMLConverter.mm

    r144568 r145444  
    16851685            Node* node = startContainer->childNode(startOffset);
    16861686            if (node && node->hasTagName(imgTag)) {
    1687                 NSFileWrapper *fileWrapper = fileWrapperForElement(static_cast<Element*>(node));
    1688                 NSTextAttachment *attachment = [[NSTextAttachment alloc] initWithFileWrapper:fileWrapper];
     1687                NSFileWrapper* fileWrapper = fileWrapperForElement(toElement(node));
     1688                NSTextAttachment* attachment = [[NSTextAttachment alloc] initWithFileWrapper:fileWrapper];
    16891689                [string appendAttributedString:[NSAttributedString attributedStringWithAttachment:attachment]];
    16901690                [attachment release];

  • trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

    r145422 r145444  
    540540#if ENABLE(VIDEO)
    541541    else if (renderer->isVideo()) {
    542         HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(renderer->node());
     542        HTMLMediaElement* mediaElement = toMediaElement(renderer->node());
    543543        m_graphicsLayer->setContentsToMedia(mediaElement->platformLayer());
    544544    }

  • trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

    r145156 r145444  
    13051305        return 0;
    13061306       
    1307     HTMLFrameOwnerElement* element = static_cast<HTMLFrameOwnerElement*>(renderer->node());
     1307    HTMLFrameOwnerElement* element = toFrameOwnerElement(renderer->node());
    13081308    if (Document* contentDocument = element->contentDocument()) {
    13091309        if (RenderView* view = contentDocument->renderView())
    … …  
    19941994            return false;
    19951995
    1996         HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(node);
     1996        HTMLMediaElement* mediaElement = toMediaElement(node);
    19971997        return mediaElement->player() ? mediaElement->player()->supportsAcceleratedRendering() : false;
    19981998    }

  • trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp

    r145346 r145444  
    5959HTMLPlugInImageElement* RenderSnapshottedPlugIn::plugInImageElement() const
    6060{
    61     return static_cast<HTMLPlugInImageElement*>(node());
     61    return toHTMLPlugInImageElement(node());
    6262}
    6363

  • trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp

    r142056 r145444  
    153153    // We may need the element later if we can't stretch.
    154154    if (node()->isElementNode()) {
    155         if (Element* mo = static_cast<Element*>(node())) {
     155        if (Element* mo = toElement(node())) {
    156156            AtomicString stretchyAttr = mo->getAttribute(MathMLNames::stretchyAttr);
    157157            stretchDisabled = equalIgnoringCase(stretchyAttr, "false");
    … …  
    234234            text = new (renderArena()) RenderText(node(), StringImpl::create(&m_operator, 1));
    235235        else if (node()->isElementNode())
    236             if (Element* mo = static_cast<Element*>(node()))
     236            if (Element* mo = toElement(node()))
    237237                text = new (renderArena()) RenderText(node(), mo->textContent().replace(hyphenMinus, minusSign).impl());
    238238        // If we can't figure out the text, leave it blank.

  • trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp

    r138835 r145444  
    8787    SVGDocumentExtensions* extensions = svgExtensionsFromNode(node());
    8888    extensions->removeResource(m_id);
    89     m_id = static_cast<Element*>(node())->getIdAttribute();
     89    m_id = toElement(node())->getIdAttribute();
    9090
    9191    registerResource();

  • trunk/Source/WebKit/chromium/ChangeLog

    r145441 r145444  
     12013-03-11  Abhishek Arya  <inferno@chromium.org>
     2
     3        Replace static_cast with to* helper functions.
     4        https://bugs.webkit.org/show_bug.cgi?id=112045
     5
     6        Reviewed by Eric Seidel.
     7
     8        * src/WebFrameImpl.cpp:
     9        (WebKit::WebFrameImpl::findChildByExpression):
     10        (WebKit::WebFrameImpl::fromFrameOwnerElement):
     11        * src/WebHelperPluginImpl.cpp:
     12        (WebKit::WebHelperPluginImpl::getPlugin):
     13        * src/WebMediaPlayerClientImpl.cpp:
     14        (WebKit::WebMediaPlayerClientImpl::loadInternal):
     15        (WebKit::WebMediaPlayerClientImpl::create):
     16        * src/WebPageSerializerImpl.cpp:
     17        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
     18        (WebKit::WebPageSerializerImpl::endTagToString):
     19        (WebKit::WebPageSerializerImpl::buildContentForNode):
     20        (WebKit::WebPageSerializerImpl::collectTargetFrames):
     21        * src/WebViewImpl.cpp:
     22        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
     23        (WebKit::WebViewImpl::enterFullScreenForElement):
     24
    1252013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
    226

  • trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

    r145345 r145444  
    750750    if (!node || !node->isFrameOwnerElement())
    751751        return 0;
    752     HTMLFrameOwnerElement* frameElement = static_cast<HTMLFrameOwnerElement*>(node);
     752    HTMLFrameOwnerElement* frameElement = toFrameOwnerElement(node);
    753753    return fromFrame(frameElement->contentFrame());
    754754}
    … …  
    22732273    if (!element || !element->isFrameOwnerElement() || (!element->hasTagName(HTMLNames::iframeTag) && !element->hasTagName(HTMLNames::frameTag)))
    22742274        return 0;
    2275     HTMLFrameOwnerElement* frameElement = static_cast<HTMLFrameOwnerElement*>(element);
     2275    HTMLFrameOwnerElement* frameElement = toFrameOwnerElement(element);
    22762276    return fromFrame(frameElement->contentFrame());
    22772277}

  • trunk/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp

    r145319 r145444  
    167167    Node* node = objectElements->item(0);
    168168    ASSERT(node->hasTagName(WebCore::HTMLNames::objectTag));
    169     WebCore::Widget* widget = static_cast<HTMLPlugInElement*>(node)->pluginWidget();
     169    WebCore::Widget* widget = toHTMLPlugInElement(node)->pluginWidget();
    170170    if (!widget)
    171171        return 0;

  • trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp

    r130530 r145444  
    384384            result.append('>');
    385385            // FIXME: This code is horribly wrong.  WebPageSerializerImpl must die.
    386             if (!static_cast<const HTMLElement*>(element)->ieForbidsInsertHTML()) {
     386            if (!toHTMLElement(element)->ieForbidsInsertHTML()) {
    387387                // We need to write end tag when it is required.
    388388                result.appendLiteral("</");
    … …  
    407407    case Node::ELEMENT_NODE:
    408408        // Process open tag of element.
    409         openTagToString(static_cast<Element*>(node), param);
     409        openTagToString(toElement(node), param);
    410410        // Walk through the children nodes and process it.
    411411        for (Node *child = node->firstChild(); child; child = child->nextSibling())
    412412            buildContentForNode(child, param);
    413413        // Process end tag of element.
    414         endTagToString(static_cast<Element*>(node), param);
     414        endTagToString(toElement(node), param);
    415415        break;
    416416    case Node::TEXT_NODE:
    … …  
    484484            if (!node->isHTMLElement())
    485485                continue;
    486             Element* element = static_cast<Element*>(node);
     486            Element* element = toElement(node);
    487487            WebFrameImpl* webFrame =
    488488                WebFrameImpl::fromFrameOwnerElement(element);

  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r145319 r145444  
    10291029            return false;
    10301030        }
    1031         Element* element = static_cast<Element*>(node);
     1031        Element* element = toElement(node);
    10321032        if (!element->hasLocalName(HTMLNames::inputTag)) {
    10331033            ASSERT_NOT_REACHED();
    … …  
    10401040            return false;
    10411041
    1042         WebString name = WebInputElement(static_cast<HTMLInputElement*>(element)).nameForAutofill();
     1042        WebString name = WebInputElement(toHTMLInputElement(element)).nameForAutofill();
    10431043        WebString value = m_autofillPopupClient->itemText(selectedIndex);
    10441044        m_autofillClient->removeAutocompleteSuggestion(name, value);
    … …  
    19751975#if USE(NATIVE_FULLSCREEN_VIDEO)
    19761976    if (element && element->isMediaElement()) {
    1977         HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(element);
     1977        HTMLMediaElement* mediaElement = toMediaElement(element);
    19781978        if (mediaElement->player() && mediaElement->player()->canEnterFullscreen()) {
    19791979            mediaElement->player()->enterFullscreen();

  • trunk/Source/WebKit/mac/ChangeLog

    r145414 r145444  
     12013-03-11  Abhishek Arya  <inferno@chromium.org>
     2
     3        Replace static_cast with to* helper functions.
     4        https://bugs.webkit.org/show_bug.cgi?id=112045
     5
     6        Reviewed by Eric Seidel.
     7
     8        * WebView/WebRenderLayer.mm:
     9        (+[WebRenderLayer nameForLayer:]):
     10
    1112013-03-11  Jer Noble  <jer.noble@apple.com>
    212

  • trunk/Source/WebKit/mac/WebView/WebRenderLayer.mm

    r144568 r145444  
    5454    if (Node* node = renderer->node()) {
    5555        if (node->isElementNode())
    56             name = [name stringByAppendingFormat:@" %@", (NSString *)static_cast<Element*>(node)->tagName()];
     56            name = [name stringByAppendingFormat:@" %@", (NSString *)toElement(node)->tagName()];
    5757        if (node->hasID())
    58             name = [name stringByAppendingFormat:@" id=\"%@\"", (NSString *)static_cast<Element*>(node)->getIdAttribute()];
     58            name = [name stringByAppendingFormat:@" id=\"%@\"", (NSString *)toElement(node)->getIdAttribute()];
    5959
    6060        if (node->hasClass()) {
Note: See TracChangeset for help on using the changeset viewer.